From mboxrd@z Thu Jan 1 00:00:00 1970 From: Angelo Dureghello Date: Thu, 24 Jan 2013 17:13:49 +0100 Subject: [U-Boot] [PATCH v4 2/2] board: add support for amcore board In-Reply-To: <20130124150156.6E1D72005FC@gemini.denx.de> References: <20130123145107.GA5565@sion.sysam> <20130124150156.6E1D72005FC@gemini.denx.de> Message-ID: <20130124161349.GA11311@sion.sysam> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Wolfgang, thanks for the review, will fix all points. > > > +/* reserve 128-4KB */ > > +#define CONFIG_SYS_MONITOR_BASE (CONFIG_SYS_FLASH_BASE + 0x400) > > +#define CONFIG_SYS_MONITOR_LEN ((128-4)*1024) > > Are you sure this is sufficient? For my board/case actually seems to be more than enough. I can still change this in the future. Best Regards, Angelo Dureghello