[U-Boot] [PATCH 4/6] mxs: mmc: Allow overriding default card detect implementation

Marek Vasut
2013-01-24T18:34:50Z

Dear Stefano Babic,
[...]

> > > diff --git a/board/bluegiga/apx4devkit/apx4devkit.c
> > > b/board/bluegiga/apx4devkit/apx4devkit.c index 029b973..5927693 100644
> > > --- a/board/bluegiga/apx4devkit/apx4devkit.c
> > > +++ b/board/bluegiga/apx4devkit/apx4devkit.c
> > > @@ -69,7 +69,7 @@ int board_init(void)
> > >
> > > #ifdef CONFIG_CMD_MMC
> > > int board_mmc_init(bd_t *bis)
> > > {
> > >
> > > - return mxsmmc_initialize(bis, 0, NULL);
> > > + return mxsmmc_initialize(bis, 0, NULL, NULL);
> >
> > I see, but it seems to me that mxs is doing different as other SOCs. If
> > there is nothing to set, cpu_mmc_init() should be used, dropping
> > board_mmc_init(). And we implement board_mmc_init() only for boards that
> > really need it, not for all.
>
> That's also an option ... do you want subsequent patch or respin of the
> series?

Actually, check how it's distributed:

$ git grep mxsmmc_initialize board | sed "s at .*/@@"
apx4devkit.c: return mxsmmc_initialize(bis, 0, NULL, NULL);
m28evk.c: return mxsmmc_initialize(bis, 0, m28_mmc_wp, NULL);
mx28evk.c: return mxsmmc_initialize(bis, 0, mx28evk_mmc_wp, NULL);
mx23_olinuxino.c: return mxsmmc_initialize(bis, 0, NULL, mx23_olx_mmc_cd);
sc_sps_1.c: return mxsmmc_initialize(bis, 0, NULL, NULL);

We have quite a bit of variance there. I wonder if using cpu_mmc_init() is worth
it.

Best regards,
Marek Vasut