* [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting
@ 2013-01-26 19:15 Otavio Salvador
2013-01-26 19:15 ` [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets Otavio Salvador
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Otavio Salvador @ 2013-01-26 19:15 UTC (permalink / raw)
To: u-boot
The power switch option is compatible with i.MX23 and i.MX28 so the
configration option needs to reflect it. We choose
'CONFIG_SPL_MXS_PSWITCH_WAIT' for the option name.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
arch/arm/cpu/arm926ejs/mxs/mxs_init.h | 2 +-
arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
index 2ddc5bc..084def5 100644
--- a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
+++ b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
@@ -30,7 +30,7 @@ void early_delay(int delay);
void mxs_power_init(void);
-#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT
+#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT
void mxs_power_wait_pswitch(void);
#else
static inline void mxs_power_wait_pswitch(void) { }
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
index e9d6302..287c698 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
@@ -921,7 +921,7 @@ void mxs_power_init(void)
early_delay(1000);
}
-#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT
+#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT
void mxs_power_wait_pswitch(void)
{
struct mxs_power_regs *power_regs =
--
1.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets
2013-01-26 19:15 [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Otavio Salvador
@ 2013-01-26 19:15 ` Otavio Salvador
2013-01-26 21:18 ` Marek Vasut
2013-01-26 19:15 ` [U-Boot] [PATCH 3/3] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-01-26 21:17 ` [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Marek Vasut
2 siblings, 1 reply; 5+ messages in thread
From: Otavio Salvador @ 2013-01-26 19:15 UTC (permalink / raw)
To: u-boot
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
index 836e636..a9efd87 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
@@ -90,7 +90,7 @@ static uint32_t dram_vals[] = {
#elif defined(CONFIG_MX23)
0x01010001, 0x00010100, 0x01000101, 0x00000001,
0x00000101, 0x00000000, 0x00010000, 0x01000001,
- 0x00000000, 0x00000001, 0x07000200, 0x00070202,
+ 0x01000000, 0x00000001, 0x07000200, 0x00070202,
0x02020000, 0x04040a01, 0x00000201, 0x02040000,
0x02000000, 0x19000f08, 0x0d0d0000, 0x02021313,
0x02061521, 0x0000000a, 0x00080008, 0x00200020,
--
1.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 3/3] mx23evk: Adjust DRAM control register to use full 128MB of RAM
2013-01-26 19:15 [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Otavio Salvador
2013-01-26 19:15 ` [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets Otavio Salvador
@ 2013-01-26 19:15 ` Otavio Salvador
2013-01-26 21:17 ` [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Otavio Salvador @ 2013-01-26 19:15 UTC (permalink / raw)
To: u-boot
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
board/freescale/mx23evk/spl_boot.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/board/freescale/mx23evk/spl_boot.c b/board/freescale/mx23evk/spl_boot.c
index 6007433..b6f4e7e 100644
--- a/board/freescale/mx23evk/spl_boot.c
+++ b/board/freescale/mx23evk/spl_boot.c
@@ -98,6 +98,16 @@ const iomux_cfg_t iomux_setup[] = {
(MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL),
};
+#define HW_DRAM_CTL14 (0x38 >> 2)
+#define CS_MAP 0x3
+#define INTAREF 0x2
+#define HW_DRAM_CTL14_CONFIG (INTAREF << 8 | CS_MAP)
+
+void mxs_adjust_memory_params(uint32_t *dram_vals)
+{
+ dram_vals[HW_DRAM_CTL14] = HW_DRAM_CTL14_CONFIG;
+}
+
void board_init_ll(void)
{
mxs_common_spl_init(iomux_setup, ARRAY_SIZE(iomux_setup));
--
1.8.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting
2013-01-26 19:15 [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Otavio Salvador
2013-01-26 19:15 ` [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets Otavio Salvador
2013-01-26 19:15 ` [U-Boot] [PATCH 3/3] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
@ 2013-01-26 21:17 ` Marek Vasut
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2013-01-26 21:17 UTC (permalink / raw)
To: u-boot
Dear Otavio Salvador,
> The power switch option is compatible with i.MX23 and i.MX28 so the
> configration option needs to reflect it. We choose
> 'CONFIG_SPL_MXS_PSWITCH_WAIT' for the option name.
The Subject should be "Rename CONFIG_SPL_MX28_PSWITCH_WAIT to
CONFIG_SPL_MXS_PSWITCH_WAIT" or something
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> arch/arm/cpu/arm926ejs/mxs/mxs_init.h | 2 +-
> arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
> b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h index 2ddc5bc..084def5 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
> +++ b/arch/arm/cpu/arm926ejs/mxs/mxs_init.h
> @@ -30,7 +30,7 @@ void early_delay(int delay);
>
> void mxs_power_init(void);
>
> -#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT
> +#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT
> void mxs_power_wait_pswitch(void);
> #else
> static inline void mxs_power_wait_pswitch(void) { }
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c index e9d6302..287c698
> 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_power_init.c
> @@ -921,7 +921,7 @@ void mxs_power_init(void)
> early_delay(1000);
> }
>
> -#ifdef CONFIG_SPL_MX28_PSWITCH_WAIT
> +#ifdef CONFIG_SPL_MXS_PSWITCH_WAIT
> void mxs_power_wait_pswitch(void)
> {
> struct mxs_power_regs *power_regs =
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets
2013-01-26 19:15 ` [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets Otavio Salvador
@ 2013-01-26 21:18 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2013-01-26 21:18 UTC (permalink / raw)
To: u-boot
Dear Otavio Salvador,
What does "bit 24" mean and what impact does it have? Commit message is missing.
Also, I don't see patch 3/3
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c index 836e636..a9efd87 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> @@ -90,7 +90,7 @@ static uint32_t dram_vals[] = {
> #elif defined(CONFIG_MX23)
> 0x01010001, 0x00010100, 0x01000101, 0x00000001,
> 0x00000101, 0x00000000, 0x00010000, 0x01000001,
> - 0x00000000, 0x00000001, 0x07000200, 0x00070202,
> + 0x01000000, 0x00000001, 0x07000200, 0x00070202,
> 0x02020000, 0x04040a01, 0x00000201, 0x02040000,
> 0x02000000, 0x19000f08, 0x0d0d0000, 0x02021313,
> 0x02061521, 0x0000000a, 0x00080008, 0x00200020,
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-01-26 21:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-26 19:15 [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Otavio Salvador
2013-01-26 19:15 ` [U-Boot] [PATCH 2/3] mx23: Enable bit 24 of HW_DRAM_CTL08 as did in imx-bootlets Otavio Salvador
2013-01-26 21:18 ` Marek Vasut
2013-01-26 19:15 ` [U-Boot] [PATCH 3/3] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-01-26 21:17 ` [U-Boot] [PATCH 1/3] mxs: Use SoC agnostic configuration option for power switch setting Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox