From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 2/2] mx23_olinuxino: Add support for status LED
Date: Mon, 28 Jan 2013 16:23:04 +0100 [thread overview]
Message-ID: <201301281623.04664.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKoTO5468xwpnk6FESsBfVd+459Y8x7ZSGmkpZ5Q2duEmA@mail.gmail.com>
Dear Otavio Salvador,
> On Mon, Jan 28, 2013 at 1:18 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Mon, Jan 28, 2013 at 1:10 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Otavio Salvador,
> >> >
> >> > [..]
> >> >
> >> >> /*
> >> >>
> >> >> + * Status LED
> >> >> + */
> >> >> +#define CONFIG_STATUS_LED
> >> >> +#define CONFIG_GPIO_LED
> >> >> +#define CONFIG_BOARD_SPECIFIC_LED
> >> >> +#define STATUS_LED_BOOT 0
> >> >> +#define STATUS_LED_BIT 0x030a /*
> >> >> MX23_PAD_SSP1_DETECT__GPIO_2_1 */
> >> >
> >> > Just use MX23_PAD_SSP1_DETECT__GPIO_2_1 directly ?
> >>
> >> make[1]: Nothing to be done for `all'.
> >> make[1]: Leaving directory `/home/otavio/hacking/u-boot/drivers/mtd/spi'
> >> status_led.c:46:7: error: 'MX23_PAD_SSP1_DETECT__GPIO_2_1' undeclared
> >> here (not in a function)
> >
> > #include iomux-mx23 missing ?
>
> ...
> make[1]: Entering directory `/home/otavio/hacking/u-boot/tools'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h: Assembler messages:
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:38: Error: bad
> instruction `typedef u32 iomux_cfg_t'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:112: Error: bad
> instruction `static inline unsigned int PAD_BANK(iomux_cfg_t pad)'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:113: Error: junk
> at end of line, first unrecognized character is `{'
> /home/otavio/hacking/u-boot/include/asm/arch/iomux.h:114: Error: bad
> instruction `return (pad&((iomux_cfg_t)0x7<<0))>>0'
> ...
>
> I had try it before of course ;)
So iomux.h is not safe to be included in assembler fixes ... fix it with some
ifdef __ASSEMBLY__ as the rest of the header files are .
Best regards,
Marek Vasut
prev parent reply other threads:[~2013-01-28 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 15:11 [U-Boot] [PATCH v3 1/2] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-28 15:11 ` [U-Boot] [PATCH v3 2/2] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-28 15:10 ` Marek Vasut
2013-01-28 15:12 ` Otavio Salvador
2013-01-28 15:18 ` Marek Vasut
2013-01-28 15:20 ` Otavio Salvador
2013-01-28 15:23 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301281623.04664.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox