From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 2/3] mxs: Fix iomux.h to not break build during assembly stage
Date: Mon, 28 Jan 2013 17:16:46 +0100 [thread overview]
Message-ID: <201301281716.46994.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKryBrYSse9s2hM9muemGn74ATx5X_8u5YwwoYJz+LXfHw@mail.gmail.com>
Dear Otavio Salvador,
> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> > Missing commit message.
>
> I think short description is clear enough. What you'd like me to put
> in long one?
Reasoning why this patch is necessary.
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> Changes in v4:
> >> - New patch
> >>
> >> Changes in v3: None
> >> Changes in v2: None
> >>
> >> arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h
> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644
> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h
> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h
> >> @@ -21,6 +21,10 @@
> >>
> >> #ifndef __MACH_MXS_IOMUX_H__
> >> #define __MACH_MXS_IOMUX_H__
> >>
> >> +#ifndef __ASSEMBLY__
> >> +
> >> +#include <asm/types.h>
> >> +
> >
> > Is this needed?
>
> Yes; or I would not have added it right? :)
Why is it needed?
> >> /*
> >>
> >> * IOMUX/PAD Bit field definitions
> >> *
> >>
> >> @@ -165,4 +169,5 @@ int mxs_iomux_setup_pad(iomux_cfg_t pad);
> >>
> >> */
> >>
> >> int mxs_iomux_setup_multiple_pads(const iomux_cfg_t *pad_list, unsigned
> >>
> >> count);
> >>
> >> +#endif /* __ASSEMBLY__ */
> >>
> >> #endif /* __MACH_MXS_IOMUX_H__*/
> >
> > Best regards,
> > Marek Vasut
>
> --
> Otavio Salvador O.S. Systems
> E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
> Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-28 16:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 15:51 [U-Boot] [PATCH v4 1/3] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-28 15:51 ` [U-Boot] [PATCH v4 2/3] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-01-28 15:57 ` Marek Vasut
2013-01-28 16:00 ` Otavio Salvador
2013-01-28 16:16 ` Marek Vasut [this message]
2013-01-28 16:30 ` Otavio Salvador
2013-01-28 16:35 ` Marek Vasut
2013-01-28 17:09 ` Otavio Salvador
2013-01-28 15:51 ` [U-Boot] [PATCH v4 3/3] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-28 18:59 ` Fabio Estevam
2013-01-28 19:12 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301281716.46994.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox