From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 28 Jan 2013 17:35:49 +0100 Subject: [U-Boot] [PATCH v4 2/3] mxs: Fix iomux.h to not break build during assembly stage In-Reply-To: References: <1359388311-25487-1-git-send-email-otavio@ossystems.com.br> <201301281716.46994.marex@denx.de> Message-ID: <201301281735.49638.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > On Mon, Jan 28, 2013 at 2:16 PM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > >> On Mon, Jan 28, 2013 at 1:57 PM, Marek Vasut wrote: > >> > Dear Otavio Salvador, > >> > > >> > Missing commit message. > >> > >> I think short description is clear enough. What you'd like me to put > >> in long one? > > > > Reasoning why this patch is necessary. > > Well, it seems quite clear it fix a build failure when it is used in > assembly stage; it is clear enough for me, in the shortlog I don't understand why did you also add the header below. That's not clear. > >> >> Signed-off-by: Otavio Salvador > >> >> --- > >> >> Changes in v4: > >> >> - New patch > >> >> > >> >> Changes in v3: None > >> >> Changes in v2: None > >> >> > >> >> arch/arm/include/asm/arch-mxs/iomux.h | 5 +++++ > >> >> 1 file changed, 5 insertions(+) > >> >> > >> >> diff --git a/arch/arm/include/asm/arch-mxs/iomux.h > >> >> b/arch/arm/include/asm/arch-mxs/iomux.h index 7abdf58..4288715 100644 > >> >> --- a/arch/arm/include/asm/arch-mxs/iomux.h > >> >> +++ b/arch/arm/include/asm/arch-mxs/iomux.h > >> >> @@ -21,6 +21,10 @@ > >> >> > >> >> #ifndef __MACH_MXS_IOMUX_H__ > >> >> #define __MACH_MXS_IOMUX_H__ > >> >> > >> >> +#ifndef __ASSEMBLY__ > >> >> + > >> >> +#include > >> >> + > >> > > >> > Is this needed? > >> > >> Yes; or I would not have added it right? :) > > > > Why is it needed? Here, I fail to understand what this has to do with fixing the inclusion of this in assembly files. Best regards, Marek Vasut