From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support
Date: Mon, 28 Jan 2013 20:56:56 +0100 [thread overview]
Message-ID: <201301282056.56862.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5DiWtwims0wAaqexOLbMWwOduZ=zWsNWBTi=yGE5URjVw@mail.gmail.com>
Dear Fabio Estevam,
> On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador
>
> <otavio@ossystems.com.br> wrote:
> > +#ifdef CONFIG_CMD_NET
> > +int board_eth_init(bd_t *bis)
> > +{
> > + /* Power-on Ethernet */
> > + gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
> > +}
> > +#endif
>
> This function expects to return an integer, and there is no return value
> here.
>
> Also, maybe you could set the GPIO inside board_early_init_f() like we
> do on mx28.
How come it didn't emit an error?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-28 19:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 19:13 [U-Boot] [PATCH 1/4] usb: mxs: Disable USB Port 1 for i.MX23 Otavio Salvador
2013-01-28 19:13 ` [U-Boot] [PATCH 2/4] mx23evk: Enable USB support Otavio Salvador
2013-01-28 19:13 ` [U-Boot] [PATCH 3/4] mx23_olinuxino: " Otavio Salvador
2013-01-28 19:15 ` Marek Vasut
2013-01-28 19:30 ` Otavio Salvador
2013-01-28 19:14 ` [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support Otavio Salvador
2013-01-28 19:12 ` Fabio Estevam
2013-01-28 19:13 ` Otavio Salvador
2013-01-28 19:17 ` Marek Vasut
2013-01-28 19:21 ` Fabio Estevam
2013-01-28 19:16 ` Marek Vasut
2013-01-28 19:48 ` Fabio Estevam
2013-01-28 19:56 ` Marek Vasut [this message]
2013-01-28 20:03 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301282056.56862.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox