From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 28 Jan 2013 20:56:56 +0100
Subject: [U-Boot] [PATCH 4/4] mx23_olinuxino: Add ethernet support
In-Reply-To: <CAOMZO5DiWtwims0wAaqexOLbMWwOduZ=zWsNWBTi=yGE5URjVw@mail.gmail.com>
References: <1359400440-12916-1-git-send-email-otavio@ossystems.com.br>
	<1359400440-12916-4-git-send-email-otavio@ossystems.com.br>
	<CAOMZO5DiWtwims0wAaqexOLbMWwOduZ=zWsNWBTi=yGE5URjVw@mail.gmail.com>
Message-ID: <201301282056.56862.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

> On Mon, Jan 28, 2013 at 5:14 PM, Otavio Salvador
> 
> <otavio@ossystems.com.br> wrote:
> > +#ifdef CONFIG_CMD_NET
> > +int board_eth_init(bd_t *bis)
> > +{
> > +       /* Power-on Ethernet */
> > +       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
> > +}
> > +#endif
> 
> This function expects to return an integer, and there is no return value
> here.
> 
> Also, maybe you could set the GPIO inside board_early_init_f() like we
> do on mx28.

How come it didn't emit an error?

Best regards,
Marek Vasut