From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] mx23: Enable tRAS lockout (24 bit of HW_DRAM_CTL08) as in imx-bootlets
Date: Tue, 29 Jan 2013 03:33:56 +0100 [thread overview]
Message-ID: <201301290333.56239.marek.vasut@gmail.com> (raw)
In-Reply-To: <1359304956-6540-2-git-send-email-otavio@ossystems.com.br>
Dear Otavio Salvador,
> This enables the 'Fast Auto Pre-Charge' found in the memory chip.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v2:
> - Improve commit message
>
> arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c index 836e636..a9efd87 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> @@ -90,7 +90,7 @@ static uint32_t dram_vals[] = {
> #elif defined(CONFIG_MX23)
> 0x01010001, 0x00010100, 0x01000101, 0x00000001,
> 0x00000101, 0x00000000, 0x00010000, 0x01000001,
> - 0x00000000, 0x00000001, 0x07000200, 0x00070202,
> + 0x01000000, 0x00000001, 0x07000200, 0x00070202,
> 0x02020000, 0x04040a01, 0x00000201, 0x02040000,
> 0x02000000, 0x19000f08, 0x0d0d0000, 0x02021313,
> 0x02061521, 0x0000000a, 0x00080008, 0x00200020,
I went through the u-boot mem init and detected you apparently added the
following undocumented portion of code (the writel((1 << 24 ...) already:
112 static void initialize_dram_values(void)
113 {
114 int i;
115
116 mxs_adjust_memory_params(dram_vals);
117
118 for (i = 0; i < ARRAY_SIZE(dram_vals); i++)
119 writel(dram_vals[i], MXS_DRAM_BASE + (4 * i));
120
121 #ifdef CONFIG_MX23
122 writel((1 << 24), MXS_DRAM_BASE + (4 * 8));
123 #endif
124 }
It does enable the TRANS_LOCKOUT. So what the heck is going on here? Are you
coding this stuff@random now ? WHAT THE FUCK IS HAPPENING HERE ?!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-29 2:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 16:42 [U-Boot] [PATCH v2 1/3] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-01-27 16:42 ` [U-Boot] [PATCH v2 2/3] mx23: Enable tRAS lockout (24 bit of HW_DRAM_CTL08) as in imx-bootlets Otavio Salvador
2013-01-27 17:16 ` Marek Vasut
2013-01-27 17:25 ` Otavio Salvador
2013-01-29 2:33 ` Marek Vasut [this message]
2013-01-29 3:14 ` Marek Vasut
2013-01-29 10:14 ` Otavio Salvador
2013-01-29 12:13 ` Marek Vasut
2013-01-29 10:10 ` Otavio Salvador
2013-01-29 12:26 ` Marek Vasut
2013-01-29 12:28 ` Otavio Salvador
2013-01-27 16:42 ` [U-Boot] [PATCH v2 3/3] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301290333.56239.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox