[U-Boot] Help : Marvell SDIO/MMC driver for Sheevaplug

[U-Boot] Help : Marvell SDIO/MMC driver for Sheevaplug

[DrEagle]

Hi all,

> > -----Original Message-----
> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> > bounces at lists.denx.de] On Behalf Of DrEagle
> > Sent: 22 September 2012 12:45
> > To: DrEagle
> > Cc: Lior Amsalem; u-boot at lists.denx.de; uboot at doukki.net
> > Subject: [U-Boot] [PATCH v2 0/5] Marvell SDIO/MMC driver for
> > Sheevaplug
> > 
> > 
> > This serie of patch add SDIO/MMC support to Sheevaplug board
> > 
> > Change from v1:
> > - Fix an issue with most SDHC cards because of timeout delay
> > 
> > drEagle (5):
> >   Add Marvell SDIO/MMC driver for Kirkwood SoC
> >   Add SDIO/MMC support for kirkwood SoC
> >   Add SDIO/MMC support for Sheevaplug board
> >   Fix env address for Sheevaplug board
> >   Fix timeout in Marvell SDIO MMC driver
>
> Hi DrEagle
> I still request you to study mvsdhci.c which is similar framework used for Pantheon family of SoCs, 
> try to use this infrastructure is possible for Kirkwood support.
>
> Regards...
> Prafulla . . .

I have started looking at sdhci component but I find only theses small details :

...
  9) mv_sdhci.c
  -------------
  This is a component of the SDHCI support, allowing it to run on Marvell
  Kirkwood chip. It is probable the SDHCI support will have to be modified to
  allow calling functions from this file based on information passed via
  platform_data.
...
  16) sdhci.c
  -----------
  Follows the new API and also has a good encapsulation of the whole driver. The
  conversion here will be simple, though it'd be necessary to modify this driver
  to also support the Kirkwood series and probably also Tegra series of CPUs.
  See the respective parts of this section for details.
...

Can anybody give me more advice on how to port efficiently a patch for SDIO/MMC for SheevaPlug/Kirkwood SoC while using, as Prafulla asked, the *sdhci* framework.

What are the best practices and the technical details which can help me into this ?

Regards,
drEagle

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130129/a7096d11/attachment.pgp>

[U-Boot] Help : Marvell SDIO/MMC driver for Sheevaplug

[Jagan Teki]

Hi,

On Tue, Jan 29, 2013 at 11:35 PM, DrEagle <dreagle@doukki.net> wrote:
> Hi all,
>
>> > -----Original Message-----
>> > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
>> > bounces at lists.denx.de] On Behalf Of DrEagle
>> > Sent: 22 September 2012 12:45
>> > To: DrEagle
>> > Cc: Lior Amsalem; u-boot at lists.denx.de; uboot at doukki.net
>> > Subject: [U-Boot] [PATCH v2 0/5] Marvell SDIO/MMC driver for
>> > Sheevaplug
>> >
>> >
>> > This serie of patch add SDIO/MMC support to Sheevaplug board
>> >
>> > Change from v1:
>> > - Fix an issue with most SDHC cards because of timeout delay
>> >
>> > drEagle (5):
>> >   Add Marvell SDIO/MMC driver for Kirkwood SoC
>> >   Add SDIO/MMC support for kirkwood SoC
>> >   Add SDIO/MMC support for Sheevaplug board
>> >   Fix env address for Sheevaplug board
>> >   Fix timeout in Marvell SDIO MMC driver
>>
>> Hi DrEagle
>> I still request you to study mvsdhci.c which is similar framework used for Pantheon family of SoCs,
>> try to use this infrastructure is possible for Kirkwood support.
>>
>> Regards...
>> Prafulla . . .
>
> I have started looking at sdhci component but I find only theses small details :
>
> ...
>   9) mv_sdhci.c
>   -------------
>   This is a component of the SDHCI support, allowing it to run on Marvell
>   Kirkwood chip. It is probable the SDHCI support will have to be modified to
>   allow calling functions from this file based on information passed via
>   platform_data.
> ...
>   16) sdhci.c
>   -----------
>   Follows the new API and also has a good encapsulation of the whole driver. The
>   conversion here will be simple, though it'd be necessary to modify this driver
>   to also support the Kirkwood series and probably also Tegra series of CPUs.
>   See the respective parts of this section for details.
> ...
>
> Can anybody give me more advice on how to port efficiently a patch for SDIO/MMC for SheevaPlug/Kirkwood SoC while using, as Prafulla asked, the *sdhci* framework.

Giving sdhci core support to your driver:
I have listed few steps that I followed while doing on my driver.
1. On your driver need to allocate a sdhci_host
2. assign your sd bases address, version, some quirks (quirks are very
impotent to change the functionalities of sdhci core)and few more...
3. call add_sdhci(sdhci_host, max_clk, min_clk)
4. any misc based on ur controller.

On my experience using with SDHCI is it is functionally an intelligent
core have issues with command delay..this may be because
it's implemented newly.

Starts using sdhci...post any issues..so-that we can tune sdhci more and more.

Thanks,
Jagan.

>
> What are the best practices and the technical details which can help me into this ?
>
> Regards,
> drEagle
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

[U-Boot] Help : Marvell SDIO/MMC driver for Sheevaplug

[Rommel G Custodio]

On 2013.01/29, DrEagle wrote:
> Hi all,
> 
> > > -----Original Message-----
> > > From: u-boot-bounces at lists.denx.de [mailto:u-boot-
> > > bounces at lists.denx.de] On Behalf Of DrEagle
> > > Sent: 22 September 2012 12:45
> > > To: DrEagle
> > > Cc: Lior Amsalem; u-boot at lists.denx.de; uboot at doukki.net
> > > Subject: [U-Boot] [PATCH v2 0/5] Marvell SDIO/MMC driver for
> > > Sheevaplug
> > > 
> > > 
> > > This serie of patch add SDIO/MMC support to Sheevaplug board
> > > 
> > > Change from v1:
> > > - Fix an issue with most SDHC cards because of timeout delay
> > > 
> > > drEagle (5):
> > >   Add Marvell SDIO/MMC driver for Kirkwood SoC
> > >   Add SDIO/MMC support for kirkwood SoC
> > >   Add SDIO/MMC support for Sheevaplug board
> > >   Fix env address for Sheevaplug board
> > >   Fix timeout in Marvell SDIO MMC driver
> >
> > Hi DrEagle
> > I still request you to study mvsdhci.c which is similar framework used for Pantheon family of SoCs, 
> > try to use this infrastructure is possible for Kirkwood support.
> >
> > Regards...
> > Prafulla . . .
> 
> I have started looking at sdhci component but I find only theses small details :
> 
> ...
>   9) mv_sdhci.c
>   -------------
>   This is a component of the SDHCI support, allowing it to run on Marvell
>   Kirkwood chip. It is probable the SDHCI support will have to be modified to
>   allow calling functions from this file based on information passed via
>   platform_data.

Slow down ...
AFAIK u-boot does not have a platform_data.
You might be confusing the Linux kernel with u-boot code.

> ...
>   16) sdhci.c
>   -----------
>   Follows the new API and also has a good encapsulation of the whole driver. The
>   conversion here will be simple, though it'd be necessary to modify this driver
>   to also support the Kirkwood series and probably also Tegra series of CPUs.
>   See the respective parts of this section for details.
> ...
> 
> Can anybody give me more advice on how to port efficiently a patch for SDIO/MMC for SheevaPlug/Kirkwood SoC while using, as Prafulla asked, the *sdhci* framework.
> 

The u-boot SDHCI framework is simple.
mmc.c and sdhci.c implements the basic core functionality for SD/MMC
access.

The developer has to define the controller as Jagan mentioned in another
e-mail. In defining the controller you can provide your register access
functions (XXX_ACCESSORS) for those host controllers that don't follow
the SD Host contoller register layout or for quirks in accessing the
registers.

All the best,
Rommel


> What are the best practices and the technical details which can help me into this ?
> 
> Regards,
> drEagle
> 



> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot