public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/10] mx23: Document the tRAS lockout setting in memory initialization
Date: Wed, 30 Jan 2013 15:10:59 +0100	[thread overview]
Message-ID: <201301301510.59940.marex@denx.de> (raw)
In-Reply-To: <1359548001-14278-3-git-send-email-otavio@ossystems.com.br>

Dear Otavio Salvador,

> Add a comment about the tRAS lockout setting of HW_DRAM_CTL08 to
> enable the 'Fast Auto Pre-Charge' found in the memory chip. The
> setting is applied after memory initialization and it is worth
> document it.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c index f8392f6..37b50e9 100644
> --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c
> @@ -119,6 +119,7 @@ static void initialize_dram_values(void)
>  		writel(dram_vals[i], MXS_DRAM_BASE + (4 * i));
> 
>  #ifdef CONFIG_MX23
> +	/* Enable tRAS lockout in HW_DRAM_CTL08 */

This does not explain why it must be here and not in the dram_vals table. It 
would be nice to explain it here, since it'd prevent others from sending patch 
stuffing it into the dram_vals table without knowing it must definitelly be 
here.

But why does it have to be here? I wonder ...

>  	writel((1 << 24), MXS_DRAM_BASE + (4 * 8));
>  #endif
>  }

Best regards,
Marek Vasut

  reply	other threads:[~2013-01-30 14:10 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 12:13 [U-Boot] [PATCH 0/10] mx23/mxs pending patches Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 01/10] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-01-30 14:11   ` Marek Vasut
2013-01-30 15:29     ` Otavio Salvador
2013-02-01 23:42       ` Simon Glass
2013-01-30 12:13 ` [U-Boot] [PATCH 02/10] mx23: Document the tRAS lockout setting in memory initialization Otavio Salvador
2013-01-30 14:10   ` Marek Vasut [this message]
2013-01-30 15:23     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 03/10] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-01-30 14:12   ` Marek Vasut
2013-01-30 15:34     ` Otavio Salvador
2013-01-30 15:38       ` Marek Vasut
2013-01-30 15:46         ` Otavio Salvador
2013-01-30 15:55           ` Marek Vasut
2013-01-30 16:00             ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 04/10] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 05/10] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-01-30 12:24   ` Fabio Estevam
2013-01-30 12:28     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 06/10] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-30 14:13   ` Marek Vasut
2013-01-30 15:34     ` Otavio Salvador
2013-01-30 15:39       ` Marek Vasut
2013-01-30 15:50         ` Otavio Salvador
2013-01-30 16:05           ` Marek Vasut
2013-01-30 16:08             ` Otavio Salvador
2013-01-30 16:15               ` Marek Vasut
2013-01-30 17:02                 ` Otavio Salvador
2013-01-30 18:14                   ` Marek Vasut
2013-01-30 12:13 ` [U-Boot] [PATCH 07/10] usb: mxs: Disable USB Port 1 for i.MX23 Otavio Salvador
2013-01-30 14:17   ` Marek Vasut
2013-01-30 15:36     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 08/10] mx23evk: Enable USB support Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 09/10] mx23_olinuxino: " Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support Otavio Salvador
2013-01-30 14:18   ` Marek Vasut
2013-01-30 15:38     ` Otavio Salvador
2013-01-30 15:40       ` Marek Vasut
2013-01-30 15:51         ` Otavio Salvador
2013-01-30 16:06           ` Marek Vasut
2013-01-30 16:09             ` Otavio Salvador
2013-01-30 16:16               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301301510.59940.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox