From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 30 Jan 2013 15:17:39 +0100 Subject: [U-Boot] [PATCH 07/10] usb: mxs: Disable USB Port 1 for i.MX23 In-Reply-To: <1359548001-14278-8-git-send-email-otavio@ossystems.com.br> References: <1359548001-14278-1-git-send-email-otavio@ossystems.com.br> <1359548001-14278-8-git-send-email-otavio@ossystems.com.br> Message-ID: <201301301517.39470.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > The i.MX23 just one USB port so disable the second controller probe > when building for i.MX23. > > Signed-off-by: Otavio Salvador > --- > drivers/usb/host/ehci-mxs.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/ehci-mxs.c b/drivers/usb/host/ehci-mxs.c > index 5062af5..28c8cde 100644 > --- a/drivers/usb/host/ehci-mxs.c > +++ b/drivers/usb/host/ehci-mxs.c > @@ -50,10 +50,12 @@ int mxs_ehci_get_port(struct ehci_mxs *mxs_usb, int > port) usb_base = MXS_USBCTRL0_BASE; > phy_base = MXS_USBPHY0_BASE; > break; > +#ifdef CONFIG_MX28 > case 1: > usb_base = MXS_USBCTRL1_BASE; > phy_base = MXS_USBPHY1_BASE; > break; > +#endif > default: > printf("CONFIG_EHCI_MXS_PORT (port = %d)\n", port); > return -1; This is not enough. For example this portion will do something undefined on mx23: 98 writel(HW_DIGCTL_CTRL_USB0_CLKGATE | HW_DIGCTL_CTRL_USB1_CLKGATE, 99 &digctl_ctrl->reg_clr); THis ehci-mxs.c needs full review for mx23. Best regards, Marek Vasut