public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support
Date: Wed, 30 Jan 2013 16:40:03 +0100	[thread overview]
Message-ID: <201301301640.03987.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKqRPg-Qux9V=JW3-LCAPH_p6N-Y7MsUk=oprfPaNbmkJg@mail.gmail.com>

Dear Otavio Salvador,

> On Wed, Jan 30, 2013 at 12:18 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> > 
> >> This adds support to the LAN9512 chip included in the board and extend
> >> the environment to easy netboot use.
> >> 
> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> ---
> >> 
> >>  board/olimex/mx23_olinuxino/mx23_olinuxino.c |  6 +++++
> >>  board/olimex/mx23_olinuxino/spl_boot.c       |  4 +++
> >>  include/configs/mx23_olinuxino.h             | 40
> >> 
> >> +++++++++++++++++++++++++--- 3 files changed, 47 insertions(+), 3
> >> deletions(-)
> >> 
> >> diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
> >> b/board/olimex/mx23_olinuxino/mx23_olinuxino.c index 2501417..9ed7718
> >> 100644
> >> --- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
> >> +++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
> >> @@ -23,6 +23,7 @@
> >> 
> >>   */
> >>  
> >>  #include <common.h>
> >> 
> >> +#include <asm/gpio.h>
> >> 
> >>  #include <asm/io.h>
> >>  #include <asm/arch/iomux-mx23.h>
> >>  #include <asm/arch/imx-regs.h>
> >> 
> >> @@ -45,6 +46,11 @@ int board_early_init_f(void)
> >> 
> >>       /* SSP0 clock at 96MHz */
> >>       mxs_set_sspclk(MXC_SSPCLK0, 96000, 0);
> >> 
> >> +#ifdef CONFIG_CMD_USB
> >> +     /* Enable LAN9512 */
> >> +     gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
> >> +#endif
> >> +
> >> 
> >>       return 0;
> >>  
> >>  }
> >> 
> >> diff --git a/board/olimex/mx23_olinuxino/spl_boot.c
> >> b/board/olimex/mx23_olinuxino/spl_boot.c index 3bbf5ad..a96c293 100644
> >> --- a/board/olimex/mx23_olinuxino/spl_boot.c
> >> +++ b/board/olimex/mx23_olinuxino/spl_boot.c
> >> @@ -95,6 +95,10 @@ const iomux_cfg_t iomux_setup[] = {
> >> 
> >>       MX23_PAD_SSP1_DATA2__SSP1_DATA2 | MUX_CONFIG_SSP,
> >>       MX23_PAD_SSP1_DATA3__SSP1_DATA3 | MUX_CONFIG_SSP,
> >>       MX23_PAD_SSP1_SCK__SSP1_SCK | MUX_CONFIG_SSP,
> >> 
> >> +
> >> +     /* Ethernet */
> >> +     MX23_PAD_GPMI_ALE__GPIO_0_17 |
> >> +             (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL),
> >> 
> >>  };
> >>  
> >>  void board_init_ll(void)
> >> 
> >> diff --git a/include/configs/mx23_olinuxino.h
> >> b/include/configs/mx23_olinuxino.h index 7e17809..42de557 100644
> >> --- a/include/configs/mx23_olinuxino.h
> >> +++ b/include/configs/mx23_olinuxino.h
> >> @@ -53,11 +53,13 @@
> >> 
> >>  #define      CONFIG_DOS_PARTITION
> >>  
> >>  #define      CONFIG_CMD_CACHE
> >> 
> >> +#define      CONFIG_CMD_DHCP
> >> 
> >>  #define      CONFIG_CMD_EXT2
> >>  #define      CONFIG_CMD_FAT
> >>  #define      CONFIG_CMD_GPIO
> >>  #define      CONFIG_CMD_LED
> >>  #define      CONFIG_CMD_MMC
> >> 
> >> +#define      CONFIG_CMD_NET
> >> 
> >>  #define      CONFIG_CMD_USB
> >>  
> >>  /*
> >> 
> >> @@ -148,6 +150,12 @@
> >> 
> >>  #define      CONFIG_USB_STORAGE
> >>  #endif
> >> 
> >> +/* Ethernet */
> >> +#ifdef       CONFIG_CMD_NET
> >> +#define      CONFIG_USB_HOST_ETHER
> >> +#define      CONFIG_USB_ETHER_SMSC95XX
> >> +#endif
> >> +
> >> 
> >>  /*
> >>  
> >>   * Boot Linux
> >>   */
> > 
> > Split the env from this patch into separate one ; merge the rest into the
> > 09/10 as the SMC device is also a hub etc.
> 
> In this case I'd prefer to add support for the hub only in the
> previous patch and left the ethernet support on this with the env.
> 
> Makes sense?

The hub and the ethernet are the same chip, thus it makes no sense to have two 
patches for that.

Best regards,
Marek Vasut

  reply	other threads:[~2013-01-30 15:40 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 12:13 [U-Boot] [PATCH 0/10] mx23/mxs pending patches Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 01/10] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-01-30 14:11   ` Marek Vasut
2013-01-30 15:29     ` Otavio Salvador
2013-02-01 23:42       ` Simon Glass
2013-01-30 12:13 ` [U-Boot] [PATCH 02/10] mx23: Document the tRAS lockout setting in memory initialization Otavio Salvador
2013-01-30 14:10   ` Marek Vasut
2013-01-30 15:23     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 03/10] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-01-30 14:12   ` Marek Vasut
2013-01-30 15:34     ` Otavio Salvador
2013-01-30 15:38       ` Marek Vasut
2013-01-30 15:46         ` Otavio Salvador
2013-01-30 15:55           ` Marek Vasut
2013-01-30 16:00             ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 04/10] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 05/10] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-01-30 12:24   ` Fabio Estevam
2013-01-30 12:28     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 06/10] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-30 14:13   ` Marek Vasut
2013-01-30 15:34     ` Otavio Salvador
2013-01-30 15:39       ` Marek Vasut
2013-01-30 15:50         ` Otavio Salvador
2013-01-30 16:05           ` Marek Vasut
2013-01-30 16:08             ` Otavio Salvador
2013-01-30 16:15               ` Marek Vasut
2013-01-30 17:02                 ` Otavio Salvador
2013-01-30 18:14                   ` Marek Vasut
2013-01-30 12:13 ` [U-Boot] [PATCH 07/10] usb: mxs: Disable USB Port 1 for i.MX23 Otavio Salvador
2013-01-30 14:17   ` Marek Vasut
2013-01-30 15:36     ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 08/10] mx23evk: Enable USB support Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 09/10] mx23_olinuxino: " Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support Otavio Salvador
2013-01-30 14:18   ` Marek Vasut
2013-01-30 15:38     ` Otavio Salvador
2013-01-30 15:40       ` Marek Vasut [this message]
2013-01-30 15:51         ` Otavio Salvador
2013-01-30 16:06           ` Marek Vasut
2013-01-30 16:09             ` Otavio Salvador
2013-01-30 16:16               ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301301640.03987.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox