From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 06/10] mx23_olinuxino: Add support for status LED
Date: Wed, 30 Jan 2013 17:05:21 +0100 [thread overview]
Message-ID: <201301301705.22076.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKp22Lr9Z8zJ7HzkeYGmt2VGz58oAVvbPP9HkjGpsqSwAw@mail.gmail.com>
Dear Otavio Salvador,
> On Wed, Jan 30, 2013 at 1:39 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Wed, Jan 30, 2013 at 12:13 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Otavio Salvador,
> >> >
> >> >> This allow user to know if the bootloader is running, even without a
> >> >> serial console.
> >> >>
> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> >
> >> > Uh oh, how does this know which GPIO to toggle to drive the led this
> >> > time ?
> >>
> >> The problem wasn't the code but me. I wasn't able to find the right
> >> GPIO number at that time.
> >
> > This is not my question. My question is how does this toggle the GPIO for
> > the LED?
>
> gpio_led driver (drivers/misc/gpio_led.c) does it.
>
> ...
> void __led_init(led_id_t mask, int state)
> {
> gpio_request(mask, "gpio_led");
> gpio_direction_output(mask, state == STATUS_LED_ON);
> }
>
> void __led_set(led_id_t mask, int state)
> {
> gpio_set_value(mask, state == STATUS_LED_ON);
> }
> ...
Ok, this didn't explain much to me.
> > Moreover, you never set the LED GPIO as output.
>
> The driver handles it by itself.
Oh ok.
Now that I did read through the code, I have few more questions:
Why can't STATUS_LED_BIT be the MX23_PAD_SSP1_DETECT__GPIO_2_1 now? Did you test
CMD_LED, does it work when toggling the LED?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-01-30 16:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 12:13 [U-Boot] [PATCH 0/10] mx23/mxs pending patches Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 01/10] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-01-30 14:11 ` Marek Vasut
2013-01-30 15:29 ` Otavio Salvador
2013-02-01 23:42 ` Simon Glass
2013-01-30 12:13 ` [U-Boot] [PATCH 02/10] mx23: Document the tRAS lockout setting in memory initialization Otavio Salvador
2013-01-30 14:10 ` Marek Vasut
2013-01-30 15:23 ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 03/10] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-01-30 14:12 ` Marek Vasut
2013-01-30 15:34 ` Otavio Salvador
2013-01-30 15:38 ` Marek Vasut
2013-01-30 15:46 ` Otavio Salvador
2013-01-30 15:55 ` Marek Vasut
2013-01-30 16:00 ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 04/10] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 05/10] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-01-30 12:24 ` Fabio Estevam
2013-01-30 12:28 ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 06/10] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-01-30 14:13 ` Marek Vasut
2013-01-30 15:34 ` Otavio Salvador
2013-01-30 15:39 ` Marek Vasut
2013-01-30 15:50 ` Otavio Salvador
2013-01-30 16:05 ` Marek Vasut [this message]
2013-01-30 16:08 ` Otavio Salvador
2013-01-30 16:15 ` Marek Vasut
2013-01-30 17:02 ` Otavio Salvador
2013-01-30 18:14 ` Marek Vasut
2013-01-30 12:13 ` [U-Boot] [PATCH 07/10] usb: mxs: Disable USB Port 1 for i.MX23 Otavio Salvador
2013-01-30 14:17 ` Marek Vasut
2013-01-30 15:36 ` Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 08/10] mx23evk: Enable USB support Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 09/10] mx23_olinuxino: " Otavio Salvador
2013-01-30 12:13 ` [U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support Otavio Salvador
2013-01-30 14:18 ` Marek Vasut
2013-01-30 15:38 ` Otavio Salvador
2013-01-30 15:40 ` Marek Vasut
2013-01-30 15:51 ` Otavio Salvador
2013-01-30 16:06 ` Marek Vasut
2013-01-30 16:09 ` Otavio Salvador
2013-01-30 16:16 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201301301705.22076.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox