[U-Boot] [PATCH 10/10] mx23_olinuxino: Add ethernet support

Otavio Salvador
2013-01-30T15:51:42Z

On Wed, Jan 30, 2013 at 1:40 PM, Marek Vasut <marex@denx.de> wrote:
> Dear Otavio Salvador,
>
>> On Wed, Jan 30, 2013 at 12:18 PM, Marek Vasut <marex@denx.de> wrote:
>> > Dear Otavio Salvador,
>> >
>> >> This adds support to the LAN9512 chip included in the board and extend
>> >> the environment to easy netboot use.
>> >>
>> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> >> ---
>> >>
>> >> board/olimex/mx23_olinuxino/mx23_olinuxino.c | 6 +++++
>> >> board/olimex/mx23_olinuxino/spl_boot.c | 4 +++
>> >> include/configs/mx23_olinuxino.h | 40
>> >>
>> >> +++++++++++++++++++++++++--- 3 files changed, 47 insertions(+), 3
>> >> deletions(-)
>> >>
>> >> diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>> >> b/board/olimex/mx23_olinuxino/mx23_olinuxino.c index 2501417..9ed7718
>> >> 100644
>> >> --- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>> >> +++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c
>> >> @@ -23,6 +23,7 @@
>> >>
>> >> */
>> >>
>> >> #include <common.h>
>> >>
>> >> +#include <asm/gpio.h>
>> >>
>> >> #include <asm/io.h>
>> >> #include <asm/arch/iomux-mx23.h>
>> >> #include <asm/arch/imx-regs.h>
>> >>
>> >> @@ -45,6 +46,11 @@ int board_early_init_f(void)
>> >>
>> >> /* SSP0 clock at 96MHz */
>> >> mxs_set_sspclk(MXC_SSPCLK0, 96000, 0);
>> >>
>> >> +#ifdef CONFIG_CMD_USB
>> >> + /* Enable LAN9512 */
>> >> + gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
>> >> +#endif
>> >> +
>> >>
>> >> return 0;
>> >>
>> >> }
>> >>
>> >> diff --git a/board/olimex/mx23_olinuxino/spl_boot.c
>> >> b/board/olimex/mx23_olinuxino/spl_boot.c index 3bbf5ad..a96c293 100644
>> >> --- a/board/olimex/mx23_olinuxino/spl_boot.c
>> >> +++ b/board/olimex/mx23_olinuxino/spl_boot.c
>> >> @@ -95,6 +95,10 @@ const iomux_cfg_t iomux_setup[] = {
>> >>
>> >> MX23_PAD_SSP1_DATA2__SSP1_DATA2 | MUX_CONFIG_SSP,
>> >> MX23_PAD_SSP1_DATA3__SSP1_DATA3 | MUX_CONFIG_SSP,
>> >> MX23_PAD_SSP1_SCK__SSP1_SCK | MUX_CONFIG_SSP,
>> >>
>> >> +
>> >> + /* Ethernet */
>> >> + MX23_PAD_GPMI_ALE__GPIO_0_17 |
>> >> + (MXS_PAD_3V3 | MXS_PAD_12MA | MXS_PAD_NOPULL),
>> >>
>> >> };
>> >>
>> >> void board_init_ll(void)
>> >>
>> >> diff --git a/include/configs/mx23_olinuxino.h
>> >> b/include/configs/mx23_olinuxino.h index 7e17809..42de557 100644
>> >> --- a/include/configs/mx23_olinuxino.h
>> >> +++ b/include/configs/mx23_olinuxino.h
>> >> @@ -53,11 +53,13 @@
>> >>
>> >> #define CONFIG_DOS_PARTITION
>> >>
>> >> #define CONFIG_CMD_CACHE
>> >>
>> >> +#define CONFIG_CMD_DHCP
>> >>
>> >> #define CONFIG_CMD_EXT2
>> >> #define CONFIG_CMD_FAT
>> >> #define CONFIG_CMD_GPIO
>> >> #define CONFIG_CMD_LED
>> >> #define CONFIG_CMD_MMC
>> >>
>> >> +#define CONFIG_CMD_NET
>> >>
>> >> #define CONFIG_CMD_USB
>> >>
>> >> /*
>> >>
>> >> @@ -148,6 +150,12 @@
>> >>
>> >> #define CONFIG_USB_STORAGE
>> >> #endif
>> >>
>> >> +/* Ethernet */
>> >> +#ifdef CONFIG_CMD_NET
>> >> +#define CONFIG_USB_HOST_ETHER
>> >> +#define CONFIG_USB_ETHER_SMSC95XX
>> >> +#endif
>> >> +
>> >>
>> >> /*
>> >>
>> >> * Boot Linux
>> >> */
>> >
>> > Split the env from this patch into separate one ; merge the rest into the
>> > 09/10 as the SMC device is also a hub etc.
>>
>> In this case I'd prefer to add support for the hub only in the
>> previous patch and left the ethernet support on this with the env.
>>
>> Makes sense?
>
> The hub and the ethernet are the same chip, thus it makes no sense to have two
> patches for that.

I'd like to have all changes of ethernet in a single commit so the
enviroment and all the other changes for it in one logical change. I
agree about the hub but the ethernet does not seem right to merge it
there.

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br