public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC Patch v6] Consolidate bool type
Date: Wed, 30 Jan 2013 15:24:25 -0800	[thread overview]
Message-ID: <20130130232424.GA18984@badger> (raw)
In-Reply-To: <5109A844.1040608@freescale.com>

On Wed, Jan 30, 2013 at 03:09:56PM -0800, York Sun wrote:
> On 01/30/2013 02:53 PM, Allen Martin wrote:
> > On Wed, Jan 30, 2013 at 11:47:57AM -0800, York Sun wrote:
> >> On 01/30/2013 11:40 AM, Allen Martin wrote:
> >>> On Wed, Jan 30, 2013 at 10:37:30AM -0800, York Sun wrote:
> >>>> On 01/24/2013 05:00 PM, Allen Martin wrote:
> >>>>> I think you can drop the RFC from your patch at this point.
> >>>>>
> >>>>> Built on all tegra20 and tegra30 devices with USE_PRIVATE_LIBGCC.
> >>>>> Tested on seaboard (tegra20).
> >>>>>
> >>>>> I've also submitted your patch to my build regression script which
> >>>>> will build all 1100+ boards against your patch and tell if there are
> >>>>> any build regressions.  I'll let you know the results tomorrow.
> >>>>>
> >>>>
> >>>> Allen,
> >>>>
> >>>> Is any change needed?
> >>>>
> >>>
> >>> Hi York, sorry I forgot to get back to you.  I ran your patch through
> >>> all boards and so no warning or error build regressions.  Looking at
> >>> the logs it looks like I ran it on version 5 not version 6 of your
> >>> patch though.  I'll do another run tonight on version 6 and let you
> >>> know the results.  I don't anticipate any problems though as it looks
> >>> like the only differences are dropping the python files and whitespace
> >>> changes. 
> >>>
> >>
> >> Allen,
> >>
> >> Your help is greatly appreciated.
> >>
> >> York
> >>
> > 
> > Compiled against all boards, no warning or error regressions
> > detected.  Tested on tegra20 trimslice and tegra30 cardhu.
> > 
> > Acked-by: Allen Martin <amartin@nvidia.com>
> > 
> 
> Thanks a lot, Allen. I will send v7 with RFC removed from subject and
> add your ack.
> 
> York
> 

Thank you for taking on such a monster of a patch!

Also, either my blackfin toolchain is broken, or every blackfin board
doesn't compile (even without this patch).  You may want to have
someone who has a known working blackfin build check the patch too.

-Allen
-- 
nvpublic

      reply	other threads:[~2013-01-30 23:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 23:12 [U-Boot] [RFC Patch v6] Consolidate bool type York Sun
2013-01-25  1:00 ` Allen Martin
2013-01-30 18:37   ` York Sun
2013-01-30 19:40     ` Allen Martin
2013-01-30 19:47       ` York Sun
2013-01-30 22:53         ` Allen Martin
2013-01-30 23:09           ` York Sun
2013-01-30 23:24             ` Allen Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130232424.GA18984@badger \
    --to=amartin@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox