From mboxrd@z Thu Jan 1 00:00:00 1970 From: Allen Martin Date: Wed, 30 Jan 2013 15:24:25 -0800 Subject: [U-Boot] [RFC Patch v6] Consolidate bool type In-Reply-To: <5109A844.1040608@freescale.com> References: <1359069137-24238-1-git-send-email-yorksun@freescale.com> <20130125010005.GB3769@badger> <5109686A.8050209@freescale.com> <20130130194014.GA12258@badger> <510978ED.1090605@freescale.com> <20130130225321.GA18391@badger> <5109A844.1040608@freescale.com> Message-ID: <20130130232424.GA18984@badger> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 30, 2013 at 03:09:56PM -0800, York Sun wrote: > On 01/30/2013 02:53 PM, Allen Martin wrote: > > On Wed, Jan 30, 2013 at 11:47:57AM -0800, York Sun wrote: > >> On 01/30/2013 11:40 AM, Allen Martin wrote: > >>> On Wed, Jan 30, 2013 at 10:37:30AM -0800, York Sun wrote: > >>>> On 01/24/2013 05:00 PM, Allen Martin wrote: > >>>>> I think you can drop the RFC from your patch at this point. > >>>>> > >>>>> Built on all tegra20 and tegra30 devices with USE_PRIVATE_LIBGCC. > >>>>> Tested on seaboard (tegra20). > >>>>> > >>>>> I've also submitted your patch to my build regression script which > >>>>> will build all 1100+ boards against your patch and tell if there are > >>>>> any build regressions. I'll let you know the results tomorrow. > >>>>> > >>>> > >>>> Allen, > >>>> > >>>> Is any change needed? > >>>> > >>> > >>> Hi York, sorry I forgot to get back to you. I ran your patch through > >>> all boards and so no warning or error build regressions. Looking at > >>> the logs it looks like I ran it on version 5 not version 6 of your > >>> patch though. I'll do another run tonight on version 6 and let you > >>> know the results. I don't anticipate any problems though as it looks > >>> like the only differences are dropping the python files and whitespace > >>> changes. > >>> > >> > >> Allen, > >> > >> Your help is greatly appreciated. > >> > >> York > >> > > > > Compiled against all boards, no warning or error regressions > > detected. Tested on tegra20 trimslice and tegra30 cardhu. > > > > Acked-by: Allen Martin > > > > Thanks a lot, Allen. I will send v7 with RFC removed from subject and > add your ack. > > York > Thank you for taking on such a monster of a patch! Also, either my blackfin toolchain is broken, or every blackfin board doesn't compile (even without this patch). You may want to have someone who has a known working blackfin build check the patch too. -Allen -- nvpublic