public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] vfat: Fix mkcksum argument sizes
Date: Thu, 31 Jan 2013 21:53:42 +0100	[thread overview]
Message-ID: <201301312153.43118.marex@denx.de> (raw)
In-Reply-To: <20130131194407.GJ30932@bill-the-cat>

Dear Tom Rini,

> On Fri, Jan 11, 2013 at 03:35:48AM -0000, Marek Vasut wrote:
> > In case a function argument is known/fixed size array in C, the argument
> > is still decoyed as pointer instead ( T f(U n[k]) ~= T fn(U *n) ) and
> > therefore calling sizeof on the function argument will result in the
> > size of the pointer, not the size of the array.
> > 
> > The VFAT code contains such a bug, this patch fixes it.
> > 
> > Reported-by: Aaron Williams <Aaron.Williams@cavium.com>
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Tom Rini <tom.rini@gmail.com>
> > Cc: Aaron Williams <Aaron.Williams@cavium.com>
> > Tested-by: Michal Simek <michal.simek@xilinx.com>
> > Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
> 
> Applied to u-boot/master, thanks!

Can we have a bugfix release 2013.02 or something ? This is a grave bug.

Best regards,
Marek Vasut

      reply	other threads:[~2013-01-31 20:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-11 13:35 [U-Boot] [PATCH] vfat: Fix mkcksum argument sizes Marek Vasut
2013-01-28 15:12 ` Michal Simek
2013-01-31 15:34 ` Joe Hershberger
2013-01-31 19:44 ` [U-Boot] " Tom Rini
2013-01-31 20:53   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201301312153.43118.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox