public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] Refactor linker-generated arrays
Date: Mon, 4 Feb 2013 09:51:24 +0100	[thread overview]
Message-ID: <20130204095124.1dd56126@lilith> (raw)
In-Reply-To: <510F6F6E.8080200@denx.de>

Hi Heiko,

On Mon, 04 Feb 2013 09:21:02 +0100, Heiko Schocher <hs@denx.de> wrote:

> Hello Albert,
> 
> On 02.02.2013 18:02, Albert ARIBAUD wrote:
> > Refactor linker-generated array code so that symbols
> > which were previously linker-generated are now compiler-
> > generated. This causes relocation records of type
> > R_ARM_ABS32 to become R_ARM_RELATIVE, which makes
> > code which uses LGA able to run before relocation as
> > well as after.
> > 
> > Note: this affects more than ARM targets, as linker-
> > lists span possibly all target architectures, notably
> > PowerPC.
> > 
> > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > ---
> 
> for arm926ejs
> 
> Tested-by: Heiko Schocher <hs@denx.de>

Thanks!

> Just one minor comment ...
> 
> [...]
> > diff --git a/common/command.c b/common/command.c
> > index 50c8429..6ac59e4 100644
> > --- a/common/command.c
> > +++ b/common/command.c
> > @@ -507,6 +507,7 @@ static int cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> >  	int result;
> >  
> >  	result = (cmdtp->cmd)(cmdtp, flag, argc, argv);
> > +
> 
> remove this Codingstyle change please.

Sorry, should have triple-checked that -- this single blank line change
in common/command.c stems from ad hoc code I'd added here for test
purposes when the patch was only proof-of-concept. Will fix in V2.

> bye,
> Heiko

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-02-04  8:51 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-02 17:02 [U-Boot] [PATCH v1 0/1] Get rid of R_ARM_ABS32 relocation records Albert ARIBAUD
2013-02-02 17:02 ` [U-Boot] [PATCH v1] Refactor linker-generated arrays Albert ARIBAUD
2013-02-02 17:51   ` Daniel Schwierzeck
2013-02-02 17:53     ` Marek Vasut
2013-02-02 18:30   ` Heiko Schocher
2013-02-02 18:42   ` Jeroen Hofstee
2013-02-04  8:21   ` Heiko Schocher
2013-02-04  8:51     ` Albert ARIBAUD [this message]
2013-02-04 12:41   ` Andreas Bießmann
2013-02-04 14:22     ` Albert ARIBAUD
2013-02-16 18:20     ` Albert ARIBAUD
2013-02-18 10:39       ` Andreas Bießmann
2013-02-18 10:42         ` Andreas Bießmann
2013-02-18 16:48           ` Albert ARIBAUD
2013-02-25 10:58   ` [U-Boot] [PATCH v2 0/4] Get rid of R_ARM_ABS32 relocation records Albert ARIBAUD
2013-02-25 10:58     ` [U-Boot] [PATCH v2 1/4] arm: omap: map u_boot_lists section to .sram Albert ARIBAUD
2013-02-25 10:58       ` [U-Boot] [PATCH v2 2/4] Remove linker lists (LGAs) from SPL linker scripts Albert ARIBAUD
2013-02-25 10:58         ` [U-Boot] [PATCH v2 3/4] arm: make __bss_start and __bss_end__ compiler-generated Albert ARIBAUD
2013-02-25 10:59           ` [U-Boot] [PATCH v2 4/4] Refactor linker-generated arrays Albert ARIBAUD
2013-02-25 11:32     ` [U-Boot] [PATCH v2 0/4] Get rid of R_ARM_ABS32 relocation records Marek Vasut
2013-02-25 15:19     ` Tom Rini
2013-02-25 16:20       ` Daniel Schwierzeck
2013-03-13 18:39         ` Tom Rini
2013-02-25 17:22       ` Albert ARIBAUD
2013-03-13 21:15     ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130204095124.1dd56126@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox