public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] common/cmd_disk.c doesn't actually define any "commands"
Date: Mon, 4 Feb 2013 15:26:41 +0100	[thread overview]
Message-ID: <20130204152641.72e869ca@lilith> (raw)
In-Reply-To: <20130204075343.1565460p912ggt44@crashcourse.ca>

Hi Robert,

On Mon, 04 Feb 2013 07:53:43 -0500, "Robert P. J. Day"
<rpjday@crashcourse.ca> wrote:

>    another observation from my weekend perusal of all of the  
> common/cmd_*.c files is that, despite its "cmd_" filename prefix, the  
> source file cmd_disk.c doesn't define any actual u-boot commands.   
> according to what i see as u-boot filename naming conventions, it  
> shouldn't be named "cmd_*", should it?

That's arguable: apparently it provides common_diskboot() which
implements commands for cmd_ide, cmd_scsi, cmd_usb which use it for
implementing their do_diskboot, du_scsiboot, do_usbboot commands
respectively. It's purely related to cmd_*.

> rday

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-02-04 14:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-04 12:53 [U-Boot] common/cmd_disk.c doesn't actually define any "commands" Robert P. J. Day
2013-02-04 14:26 ` Albert ARIBAUD [this message]
2013-02-04 15:04   ` Robert P. J. Day
2013-02-04 15:17     ` Mats Kärrman
2013-02-04 15:29       ` Robert P. J. Day
2013-02-04 15:30       ` Albert ARIBAUD
2013-02-04 15:42         ` Mats Kärrman
2013-02-04 16:01           ` Albert ARIBAUD
2013-02-04 15:18     ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130204152641.72e869ca@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox