From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 4 Feb 2013 15:26:41 +0100 Subject: [U-Boot] common/cmd_disk.c doesn't actually define any "commands" In-Reply-To: <20130204075343.1565460p912ggt44@crashcourse.ca> References: <20130204075343.1565460p912ggt44@crashcourse.ca> Message-ID: <20130204152641.72e869ca@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Robert, On Mon, 04 Feb 2013 07:53:43 -0500, "Robert P. J. Day" wrote: > another observation from my weekend perusal of all of the > common/cmd_*.c files is that, despite its "cmd_" filename prefix, the > source file cmd_disk.c doesn't define any actual u-boot commands. > according to what i see as u-boot filename naming conventions, it > shouldn't be named "cmd_*", should it? That's arguable: apparently it provides common_diskboot() which implements commands for cmd_ide, cmd_scsi, cmd_usb which use it for implementing their do_diskboot, du_scsiboot, do_usbboot commands respectively. It's purely related to cmd_*. > rday Amicalement, -- Albert.