From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] common/cmd_disk.c doesn't actually define any "commands"
Date: Mon, 4 Feb 2013 16:30:17 +0100 [thread overview]
Message-ID: <20130204163017.17643abc@lilith> (raw)
In-Reply-To: <ED3E0BCACD909541BA94A34C4A164D4C429632C4@post.tritech.se>
Hi Mats,
On Mon, 4 Feb 2013 15:17:17 +0000, Mats K?rrman
<Mats.Karrman@tritech.se> wrote:
> Hi Robert, Albert,
>
> > Robert P. J. Day wrote:
> > just to be clear, i have no strong opinion on this either way, but
> > my understanding is that source files with the name of "common/cmd_*.c"
> > typically define at least one u-boot "command" with the U_BOOT_CMD macro.
> > as far as i can tell, cmd_disk.c is the only counterexample of that.
>
> I was just looking into this myself but from another perspective.
> I'm using "CONFIG_USB:STORAGE" and because of the way things are made, I then automatically
> get "usbboot" for which I have no use. Things would be more logical if it was up
> to cmd_disk to define the commands based on ifdef's for the various backends -- but
> ONLY if CONFIG_CMD_DISK was in the config file.
> Maybe this upsets a lot of other people though...?
Maybe, but the problem you state is not about cmd_disk (or I am
missing the point). USB commands are in USB related files, e.g.
do_usbboot() is in cmd_usb.c, so that's where a conditional should be
put if you want to compile the command out, rather than in cmd_disk,
which does not add to the U-Boot commands table at all.
> Best regards,
> Mats
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-02-04 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 12:53 [U-Boot] common/cmd_disk.c doesn't actually define any "commands" Robert P. J. Day
2013-02-04 14:26 ` Albert ARIBAUD
2013-02-04 15:04 ` Robert P. J. Day
2013-02-04 15:17 ` Mats Kärrman
2013-02-04 15:29 ` Robert P. J. Day
2013-02-04 15:30 ` Albert ARIBAUD [this message]
2013-02-04 15:42 ` Mats Kärrman
2013-02-04 16:01 ` Albert ARIBAUD
2013-02-04 15:18 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204163017.17643abc@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox