From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, PATCHv2] FAT: remove ifdefs to make the code more readable
Date: Mon, 4 Feb 2013 11:42:02 -0500 [thread overview]
Message-ID: <20130204164202.GG27802@bill-the-cat> (raw)
In-Reply-To: <1355405410-2783-1-git-send-email-richard.genoud@gmail.com>
On Thu, Dec 13, 2012 at 03:30:10AM -0000, Richard Genoud wrote:
> ifdefs in the code are making it harder to read.
> The use of simple if(vfat_enabled) makes no more code and is cleaner.
> (the code is discarded by the compiler instead of the preprocessor.)
> NB: if -O0 is used, the code won't be discarded
>
> and bonus, now the code compiles even if CONFIG_SUPPORT_VFAT is not
> defined.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130204/17ccf778/attachment.pgp>
next prev parent reply other threads:[~2013-02-04 16:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 13:04 [U-Boot] [PATCH] FAT: make FAT compile without VFAT Richard Genoud
2012-12-04 14:24 ` Marek Vasut
2012-12-04 15:32 ` Richard Genoud
2012-12-04 16:16 ` Stefano Babic
2012-12-13 10:47 ` [U-Boot] [PATCH 0/2] clean some FAT code Richard Genoud
2012-12-13 12:45 ` Marek Vasut
2012-12-13 12:57 ` Richard Genoud
2012-12-13 10:47 ` [U-Boot] [PATCH 1/2] FAT: remove ifdefs to make the code more readable Richard Genoud
2012-12-13 12:46 ` Marek Vasut
2012-12-13 13:00 ` Richard Genoud
2012-12-13 13:12 ` Marek Vasut
2012-12-13 13:16 ` Richard Genoud
2012-12-13 13:19 ` Marek Vasut
2012-12-13 13:30 ` [U-Boot] [PATCHv2] " Richard Genoud
2013-02-04 16:42 ` Tom Rini [this message]
2012-12-13 13:09 ` [U-Boot] [PATCH 1/2] " Tom Rini
2012-12-13 13:15 ` Richard Genoud
2012-12-13 13:51 ` Marek Vasut
2012-12-13 14:24 ` Richard Genoud
2012-12-13 14:41 ` Tom Rini
2012-12-13 10:47 ` [U-Boot] [PATCH 2/2] FAT: use toupper/tolower instead of recoding them Richard Genoud
2012-12-13 12:47 ` Marek Vasut
2012-12-14 8:56 ` Stefano Babic
2013-02-04 16:41 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204164202.GG27802@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox