From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Mon, 4 Feb 2013 17:00:25 +0100 Subject: [U-Boot] the weirdness with cmd_df.c In-Reply-To: <20130204105405.17762a72v8atypa8@crashcourse.ca> References: <20130204105405.17762a72v8atypa8@crashcourse.ca> Message-ID: <20130204170025.6971548c@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Robert, On Mon, 04 Feb 2013 10:54:05 -0500, "Robert P. J. Day" wrote: > i mentioned this this weekend as well, can someone clarify this? > the source file cmd_df.c looks weird: > > U_BOOT_CMD( > sf, 2, 1, do_serial_flash, > "Serial flash sub-system", > "probe [bus:]cs - init flash device on given SPI bus and CS") > > so the source file "cmd_df.c" allegedly defines a command called "sf", > which invokes "do_serial_flash", which isn't even defined in that > source file -- what's defined in that file is "do_df". i don't see > "do_serial_flash" defined anywhere in the u-boot source tree. am i > just being blind? i see no reference to that source file in Makefile, > so i'm guessing it's historical cruft that could be deleted? do_serial_flash() indeed does not appear anywhere. As for deleting, you should check which makefile builds cmd_df.c, under which condition, and if this condition is met in any U-Boot MAKEALL target. If not, just submit a patch to remove cmd_df.c from the baseline. BTW: IMO, you should just submit a patch instead of asking. If the patch is ok, it'll be taken, and you didn't have anything to ask; if the patch is not OK, the one who NAKs it will tell you why, and you'll get the answer without asking. :) Amicalement, -- Albert.