public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part
@ 2012-09-14 15:16 ` 402jagan at gmail.com
  2012-10-04  5:55   ` Michal Simek
  0 siblings, 1 reply; 6+ messages in thread
From: 402jagan at gmail.com @ 2012-09-14 15:16 UTC (permalink / raw)
  To: u-boot

From: Jagannadha Sutradharudu Teki <402jagan@gmail.com>

This patch corrected the first byte of idcode1 for S25FL256S SPI flash.

Signed-off-by: Jagannadha Sutradharudu Teki <402jagan@gmail.com>
---
 drivers/mtd/spi/spansion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 32b76e0..9288672 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -97,7 +97,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.name = "S25FL129P_64K",
 	},
 	{
-		.idcode1 = 0x2019,
+		.idcode1 = 0x0219,
 		.idcode2 = 0x4d01,
 		.pages_per_sector = 256,
 		.nr_sectors = 512,
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part
  2012-09-14 15:16 ` 402jagan at gmail.com
@ 2012-10-04  5:55   ` Michal Simek
  0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2012-10-04  5:55 UTC (permalink / raw)
  To: u-boot

Hi Mike,

On 09/14/2012 05:16 PM, 402jagan at gmail.com wrote:
> From: Jagannadha Sutradharudu Teki <402jagan@gmail.com>
>
> This patch corrected the first byte of idcode1 for S25FL256S SPI flash.
>
> Signed-off-by: Jagannadha Sutradharudu Teki <402jagan@gmail.com>
> ---
>   drivers/mtd/spi/spansion.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)

Can you please add this patch to your sf branch?

I have checked it at http://www.spansion.com/Support/Datasheets/S25FL128S_256S_00.pdf (page 133)
and 02 is correct for 256Mb.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part
@ 2013-01-23 12:24 Michal Simek
  2013-02-04 17:59 ` Marek Vasut
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2013-01-23 12:24 UTC (permalink / raw)
  To: u-boot

From: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>

This patch corrected the first byte of idcode1 for S25FL256S SPI flash.

Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
 drivers/mtd/spi/spansion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
index 32b76e0..9288672 100644
--- a/drivers/mtd/spi/spansion.c
+++ b/drivers/mtd/spi/spansion.c
@@ -97,7 +97,7 @@ static const struct spansion_spi_flash_params spansion_spi_flash_table[] = {
 		.name = "S25FL129P_64K",
 	},
 	{
-		.idcode1 = 0x2019,
+		.idcode1 = 0x0219,
 		.idcode2 = 0x4d01,
 		.pages_per_sector = 256,
 		.nr_sectors = 512,
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part
  2013-01-23 12:24 [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part Michal Simek
@ 2013-02-04 17:59 ` Marek Vasut
  2013-02-04 18:11   ` Michal Simek
  0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2013-02-04 17:59 UTC (permalink / raw)
  To: u-boot

Dear Michal Simek,

was this ever applied?

> From: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> 
> This patch corrected the first byte of idcode1 for S25FL256S SPI flash.
> 
> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>  drivers/mtd/spi/spansion.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/spi/spansion.c b/drivers/mtd/spi/spansion.c
> index 32b76e0..9288672 100644
> --- a/drivers/mtd/spi/spansion.c
> +++ b/drivers/mtd/spi/spansion.c
> @@ -97,7 +97,7 @@ static const struct spansion_spi_flash_params
> spansion_spi_flash_table[] = { .name = "S25FL129P_64K",
>  	},
>  	{
> -		.idcode1 = 0x2019,
> +		.idcode1 = 0x0219,
>  		.idcode2 = 0x4d01,
>  		.pages_per_sector = 256,
>  		.nr_sectors = 512,

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part
  2013-02-04 17:59 ` Marek Vasut
@ 2013-02-04 18:11   ` Michal Simek
  2013-02-04 20:52     ` Tom Rini
  0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2013-02-04 18:11 UTC (permalink / raw)
  To: u-boot

Hi,

2013/2/4 Marek Vasut <marex@denx.de>:
> Dear Michal Simek,
>
> was this ever applied?

I have sent pull request to Tom and Mike. All patches around cf are here.

http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/mainline/sf

Interesting that Tom applied this patch and don't the rest
"sf: stmicro: add support for N25Q064"

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part
  2013-02-04 18:11   ` Michal Simek
@ 2013-02-04 20:52     ` Tom Rini
  0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2013-02-04 20:52 UTC (permalink / raw)
  To: u-boot

On Mon, Feb 04, 2013 at 07:11:38PM +0100, Michal Simek wrote:
> Hi,
> 
> 2013/2/4 Marek Vasut <marex@denx.de>:
> > Dear Michal Simek,
> >
> > was this ever applied?
> 
> I have sent pull request to Tom and Mike. All patches around cf are here.
> 
> http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=shortlog;h=refs/heads/mainline/sf
> 
> Interesting that Tom applied this patch and don't the rest
> "sf: stmicro: add support for N25Q064"

I had grabbed a few things that stood out to me Friday and started a
build.  Took a bit to sort out things and in the interim you made your
pull request.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130204/5ac30fe8/attachment.pgp>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-02-04 20:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-23 12:24 [U-Boot] [PATCH] sf: spansion: Correct the first byte of idcode1 for S25FL256S part Michal Simek
2013-02-04 17:59 ` Marek Vasut
2013-02-04 18:11   ` Michal Simek
2013-02-04 20:52     ` Tom Rini
     [not found] <402jagan@gmail.com>
2012-09-14 15:16 ` 402jagan at gmail.com
2012-10-04  5:55   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox