From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 13 Feb 2013 22:12:31 +0100 Subject: [U-Boot] [PATCH v2 02/10] mx23: Document the tRAS lockout setting in memory initialization In-Reply-To: <1360589756-26355-3-git-send-email-otavio@ossystems.com.br> References: <1360589756-26355-1-git-send-email-otavio@ossystems.com.br> <1360589756-26355-3-git-send-email-otavio@ossystems.com.br> Message-ID: <201302132212.31940.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Otavio Salvador, > Add a comment about the tRAS lockout setting of HW_DRAM_CTL08 to > enable the 'Fast Auto Pre-Charge' found in the memory chip. The > setting is applied after memory initialization and it is worth > document it. > > Signed-off-by: Otavio Salvador > --- > Changes in v2: > - Extend code comment to explicit say it needs to be there. > > arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c > b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c index f8392f6..1952eac 100644 > --- a/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c > +++ b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c > @@ -119,6 +119,7 @@ static void initialize_dram_values(void) > writel(dram_vals[i], MXS_DRAM_BASE + (4 * i)); > > #ifdef CONFIG_MX23 > + /* Enable tRAS lockout in HW_DRAM_CTL08 ; it must be after all */ 'After all'? > writel((1 << 24), MXS_DRAM_BASE + (4 * 8)); > #endif > } Best regards, Marek Vasut