From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 10/10] mx23_olinuxino: Add ethernet support
Date: Thu, 14 Feb 2013 17:44:37 +0100 [thread overview]
Message-ID: <201302141744.37290.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKqxV6jvGgv6K8XOaJYxrtr+YFUddCao7_YkSJ5-+4c3oQ@mail.gmail.com>
Dear Otavio Salvador,
> On Wed, Feb 13, 2013 at 7:36 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Wed, Feb 13, 2013 at 7:19 PM, Marek Vasut <marex@denx.de> wrote:
> >> > Dear Otavio Salvador,
> >> >
> >> >> This adds support to the LAN9512 chip included in the board and
> >> >> extend the environment to easy netboot use.
> >> >>
> >> >> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >> >
> >> > You completely ignored previous discussion to make this ethernet
> >> > thingie part of the previous patch.
> >>
> >> I made the HUB part of the previous patch; I don't agree in moving
> >> ethernet to there.
> >
> > The ethernet is integral part of the hub chip. This approach you take
> > here breaks bisectability.
>
> It does not; in case you do bisect you'll be able to build and run
> both revisions; it'll be a matter of one more 'bad' command call. I
> prefer to keep it split as it is much easier for someone reading the
> history to stop what has been done.
Yes, you're adding only part of the support in one patch and the other part in
another patch. It makes no sense to me.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-02-14 16:44 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 13:35 [U-Boot] [PATCH v2 0/10] mx23/mxs pending patches Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 01/10] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 02/10] mx23: Document the tRAS lockout setting in memory initialization Otavio Salvador
2013-02-13 21:12 ` Marek Vasut
2013-02-13 21:20 ` Otavio Salvador
2013-02-13 21:31 ` Fabio Estevam
2013-02-13 21:36 ` Otavio Salvador
2013-02-13 21:39 ` Fabio Estevam
2013-02-13 21:42 ` Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 03/10] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-02-13 21:13 ` Marek Vasut
2013-02-13 21:21 ` Otavio Salvador
2013-02-13 21:33 ` Marek Vasut
2013-02-13 21:38 ` Otavio Salvador
2013-02-14 16:43 ` Marek Vasut
2013-02-11 13:35 ` [U-Boot] [PATCH v2 04/10] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 05/10] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-02-13 21:13 ` Marek Vasut
2013-02-13 21:22 ` Otavio Salvador
2013-02-13 21:34 ` Marek Vasut
2013-02-11 13:35 ` [U-Boot] [PATCH v2 06/10] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 07/10] usb: mxs: Disable USB Port 1 for i.MX23 Otavio Salvador
2013-02-13 21:15 ` Marek Vasut
2013-02-13 21:24 ` Otavio Salvador
2013-02-13 21:36 ` Marek Vasut
2013-02-16 21:59 ` Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 08/10] mx23evk: Enable USB support Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 09/10] mx23_olinuxino: " Otavio Salvador
2013-02-11 13:35 ` [U-Boot] [PATCH v2 10/10] mx23_olinuxino: Add ethernet support Otavio Salvador
2013-02-13 21:19 ` Marek Vasut
2013-02-13 21:25 ` Otavio Salvador
2013-02-13 21:36 ` Marek Vasut
2013-02-13 21:40 ` Otavio Salvador
2013-02-14 16:44 ` Marek Vasut [this message]
2013-02-14 18:24 ` Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302141744.37290.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox