From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/14] tegra114: add SPI driver
Date: Thu, 14 Feb 2013 13:49:50 -0800 [thread overview]
Message-ID: <20130214214949.GF32695@badger> (raw)
In-Reply-To: <CAPnjgZ3tsuosD7rWm3aJwnFGW2tmwTSaY+5RU8xQXhO-HKcv0g@mail.gmail.com>
On Thu, Feb 14, 2013 at 06:32:06AM -0800, Simon Glass wrote:
> Hi Allen,
>
> On Wed, Feb 13, 2013 at 2:59 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> > On 02/12/2013 08:23 PM, Allen Martin wrote:
> >> Subject: tegra114: add SPI driver
> >
> > This really touches the SPI sub-system more than Tegra, and the Tegra
> > subsystem is just (and all of) Tegra not Tegra114-specific, so I'd
> > re-title this:
> >
> > spi: tegra: add Tegra114 SPI driver
> >
> > similar s/tegra114:/tegra:/ in other patch subjects, many of which
> > probably should be "ARM: tegra: ...".
>
> This driver seems to add a lot of duplication. What prevents using
> common code? Is it the register layout, differences in algorithm or
> something else?
Yes, unfortunately there really are three different SPI controller
hardware blocks. There's "sflash" which is a tegra20 only block,
"slink" which is present in tegra20 and tegra30, and tegra114 has a
new SPI controller which is functionally equivalent to slink, but the
register interface is different.
The programming model is quite similar, but not exactly the same
between each. For example, the same function may be one register
write on one chip and two or more register writes on another. It
could be possible to hide some of those differences in macros or
inline functions, but I'm not sure if that's more or less messy.
-Allen
--
nvpublic
next prev parent reply other threads:[~2013-02-14 21:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 3:23 [U-Boot] [PATCH 00/14] tegra114 SPI driver Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 01/14] tegra: spi: rename tegra SPI drivers Allen Martin
2013-02-13 22:30 ` Stephen Warren
2013-02-14 19:58 ` Allen Martin
2013-02-14 20:18 ` Stephen Warren
2013-02-13 22:36 ` Stephen Warren
2013-02-14 20:01 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 02/14] tegra: spi: remove non fdt support Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 03/14] tegra: spi: pull register structs out of headers Allen Martin
2013-02-13 22:32 ` Stephen Warren
2013-02-14 19:20 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 04/14] tegra20: spi: move fdt probe to spi_init Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 05/14] spi: add common fdt SPI driver interface Allen Martin
2013-02-13 22:40 ` Stephen Warren
2013-02-14 20:07 ` Allen Martin
2013-02-14 20:21 ` Stephen Warren
2013-02-14 21:42 ` Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 06/14] sf: winbond: add W25Q32DW Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 07/14] tegra114: dalmore: add SPI pinmux config Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 08/14] tegra114: fdt: add compatible string for tegra114 SPI ctrl Allen Martin
2013-02-13 22:51 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 09/14] tegra114: fdt: add CAR block Allen Martin
2013-02-13 22:46 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 10/14] tegra114: fdt: add apbdma block Allen Martin
2013-02-13 22:48 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 11/14] tegra114: fdt: add SPI blocks Allen Martin
2013-02-13 22:52 ` Stephen Warren
2013-02-13 3:23 ` [U-Boot] [PATCH 12/14] tegra114: dalmore: fdt: enable dalmore SPI controller Allen Martin
2013-02-13 3:23 ` [U-Boot] [PATCH 13/14] tegra114: add SPI driver Allen Martin
2013-02-13 22:59 ` Stephen Warren
2013-02-14 14:32 ` Simon Glass
2013-02-14 21:49 ` Allen Martin [this message]
2013-02-13 3:23 ` [U-Boot] [PATCH 14/14] tegra114: dalmore: config: enable SPI Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214214949.GF32695@badger \
--to=amartin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox