[U-Boot] [PATCH v1] Refactor linker-generated arrays

Albert ARIBAUD
2013-02-04T08:51:24Z

Hi Heiko,

On Mon, 04 Feb 2013 09:21:02 +0100, Heiko Schocher <hs@denx.de> wrote:

> Hello Albert,
>
> On 02.02.2013 18:02, Albert ARIBAUD wrote:
> > Refactor linker-generated array code so that symbols
> > which were previously linker-generated are now compiler-
> > generated. This causes relocation records of type
> > R_ARM_ABS32 to become R_ARM_RELATIVE, which makes
> > code which uses LGA able to run before relocation as
> > well as after.
> >
> > Note: this affects more than ARM targets, as linker-
> > lists span possibly all target architectures, notably
> > PowerPC.
> >
> > Signed-off-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> > ---
>
> for arm926ejs
>
> Tested-by: Heiko Schocher <hs@denx.de>

Thanks!

> Just one minor comment ...
>
> [...]
> > diff --git a/common/command.c b/common/command.c
> > index 50c8429..6ac59e4 100644
> > --- a/common/command.c
> > +++ b/common/command.c
> > @@ -507,6 +507,7 @@ static int cmd_call(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> > int result;
> >
> > result = (cmdtp->cmd)(cmdtp, flag, argc, argv);
> > +
>
> remove this Codingstyle change please.

Sorry, should have triple-checked that -- this single blank line change
in common/command.c stems from ad hoc code I'd added here for test
purposes when the patch was only proof-of-concept. Will fix in V2.

> bye,
> Heiko

Amicalement,
--
Albert.