From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 9/9] dfu: Support larger than memory transfers.
Date: Mon, 18 Feb 2013 13:38:49 +0100 [thread overview]
Message-ID: <201302181338.49392.marex@denx.de> (raw)
In-Reply-To: <20130218110142.3befd1f8@amdc308.digital.local>
Dear Lukasz Majewski,
> Hi Tom,
>
> > On Fri, Nov 30, 2012 at 08:01:12PM +0200, Pantelis Antoniou wrote:
> > > We didn't support upload/download larger than available memory.
> > > This is pretty bad when you have to update your root filesystem for
> > > example.
> > >
> > > This patch removes the limitation (and the crashes when you
> > > transfered any file larger than 4MB).
> > > On top of that reduces the huge dfu buffer from 4MB to just 64K,
> > > which was over the top.
> > >
> > > The sequence number is a 16 bit counter; make sure we
> > > handle rollover correctly. This fixes the wrong transfers for
> > > large (> 256MB) images.
> > >
> > > Also utilize a variable to handle initialization, so that we
> > > don't rely on just the counter sent by the host.
> > >
> > > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> >
> > To be clear, patches 1-8 are good and we should take, but this one
> > means we can't use FAT/EXT* partitions without more work. I would
> > suggest that we set this part aside for a moment and perhaps limit
> > transfers that are larget than RAM to RAW only where we can write in
> > chunks today.
>
> As fair as I remember, some additional work needs to be done with
> composite.c file (to remove nasty #ifdefs). There was a problem with
> newer version of dfu-utils (new handling of descriptors).
>
> It is on top of my queue, but I'm currently buried with other work and
> need to postpone this.
>
> However it is still on the back of my head and I push myself to fix
> this.
Guys, can you just tell me what I should drop from u-boot-usb to submit a pullRQ
with the rest ? Otherwise I'll drop the whole DFU stuff and be done with it.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-02-18 12:38 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 18:01 [U-Boot] [PATCH v3 0/9] USB: Gadget & DFU related fixes Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 1/9] usb: Fix bug when both DFU & ETHER are defined Pantelis Antoniou
2012-12-01 5:30 ` Marek Vasut
2012-12-03 10:10 ` Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 2/9] g_dnl: Issue connect/disconnect as appropriate Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 3/9] g_dnl: Properly terminate string list Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 4/9] dfu: Only perform DFU board_usb_init() for TRATS Pantelis Antoniou
2012-12-01 5:31 ` Marek Vasut
2012-11-30 18:01 ` [U-Boot] [PATCH v3 5/9] dfu: Fix crash when wrong number of arguments given Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 6/9] dfu: Send correct DFU response from composite_setup Pantelis Antoniou
2012-12-10 17:11 ` Lukasz Majewski
2012-12-10 18:21 ` Pantelis Antoniou
2012-12-10 19:26 ` Lukasz Majewski
2012-12-11 0:47 ` Marek Vasut
2012-12-11 8:40 ` Lukasz Majewski
2012-12-11 10:47 ` Wolfgang Denk
2012-12-11 13:44 ` Tom Rini
2012-12-12 17:55 ` Marek Vasut
2012-12-12 18:03 ` Tom Rini
2012-12-11 11:02 ` Lukasz Majewski
2012-12-11 11:23 ` Pantelis Antoniou
2012-12-11 11:28 ` Robert P. J. Day
2012-12-12 21:42 ` Marek Vasut
2012-12-12 21:40 ` Marek Vasut
2012-12-11 11:18 ` Lukasz Majewski
2012-11-30 18:01 ` [U-Boot] [PATCH v3 7/9] dfu: Properly zero out timeout value Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 8/9] dfu: Add a partition type target Pantelis Antoniou
2012-11-30 18:01 ` [U-Boot] [PATCH v3 9/9] dfu: Support larger than memory transfers Pantelis Antoniou
2013-02-12 20:51 ` Tom Rini
2013-02-18 10:01 ` Lukasz Majewski
2013-02-18 12:38 ` Marek Vasut [this message]
2013-02-18 13:51 ` Tom Rini
2013-02-18 21:08 ` Tom Rini
2013-02-20 7:17 ` Lukasz Majewski
2012-12-01 5:32 ` [U-Boot] [PATCH v3 0/9] USB: Gadget & DFU related fixes Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302181338.49392.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox