From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 19 Feb 2013 02:38:24 +0100
Subject: [U-Boot] [PATCH v3 09/10] mx23_olinuxino: Enable USB support
In-Reply-To: <CAP9ODKrD6F0L+sr=_BTwmu-WFLG1-7w7FEHYP3MNQQn_3nCOEw@mail.gmail.com>
References: <1361130325-5202-1-git-send-email-otavio@ossystems.com.br>
	<CAOMZO5CJP6NcmLJ51BcjHyeA6CcENEQ1qwc+Ku8ADoAtEntr-w@mail.gmail.com>
	<CAP9ODKrD6F0L+sr=_BTwmu-WFLG1-7w7FEHYP3MNQQn_3nCOEw@mail.gmail.com>
Message-ID: <201302190238.25096.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Otavio Salvador,

> On Mon, Feb 18, 2013 at 8:16 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador
> > 
> > <otavio@ossystems.com.br> wrote:
> >> +#ifdef CONFIG_CMD_USB
> >> +       /* Enable LAN9512 */
> >> +       gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
> >> +#endif
> > 
> > What about doing like we do with other imx devices and write something
> > like:
> > 
> > gpio_direction_output(MXS_GPIO_NR(0, 17), 1);
> > 
> > ,where
> > 
> > #define MXS_GPIO_NR(bank, nr)      ((bank) * 32 + (nr))
> > 
> > This also aligns with the kernel style.
> 
> Awesome; I have added it to v5. Thx!

This will bring in quite a lot of inconsistency, will it not?

Best regards,
Marek Vasut