From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 09/10] mx23_olinuxino: Enable USB support
Date: Tue, 19 Feb 2013 13:21:26 +0100 [thread overview]
Message-ID: <201302191321.26735.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKosyPChQ+9WDF6rya1=BOyttGMMt58+NuuA-_wUd9Vg6g@mail.gmail.com>
Dear Otavio Salvador,
> On Mon, Feb 18, 2013 at 10:38 PM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Mon, Feb 18, 2013 at 8:16 PM, Fabio Estevam <festevam@gmail.com> wrote:
> >> > On Sun, Feb 17, 2013 at 4:45 PM, Otavio Salvador
> >> >
> >> > <otavio@ossystems.com.br> wrote:
> >> >> +#ifdef CONFIG_CMD_USB
> >> >> + /* Enable LAN9512 */
> >> >> + gpio_direction_output(MX23_PAD_GPMI_ALE__GPIO_0_17, 1);
> >> >> +#endif
> >> >
> >> > What about doing like we do with other imx devices and write something
> >> > like:
> >> >
> >> > gpio_direction_output(MXS_GPIO_NR(0, 17), 1);
> >> >
> >> > ,where
> >> >
> >> > #define MXS_GPIO_NR(bank, nr) ((bank) * 32 + (nr))
> >> >
> >> > This also aligns with the kernel style.
> >>
> >> Awesome; I have added it to v5. Thx!
> >
> > This will bring in quite a lot of inconsistency, will it not?
>
> Really? why?
Because this will not be used globally with all GPIOs, but only locally for this
one case. So my suggestion is to postpone this change and do this in one large
swipe afterwards.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-02-19 12:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-17 19:45 [U-Boot] [PATCH v3 0/10] mx23/mxs pending patches Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 01/10] mxs: Rename CONFIG_SPL_MX28_PSWITCH_WAIT to CONFIG_SPL_MXS_PSWITCH_WAIT Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 02/10] mx23: Document the tRAS lockout setting in memory initialization Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 03/10] mx23evk: Adjust DRAM control register to use full 128MB of RAM Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 04/10] led: Use STATUS_LED_ON and STATUS_LED_OFF when calling __led_set Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 05/10] mxs: Fix iomux.h to not break build during assembly stage Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 06/10] mx23_olinuxino: Add support for status LED Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 07/10] usb: mxs: Adapt code for i.MX23 support Otavio Salvador
2013-02-17 20:03 ` Fabio Estevam
2013-02-17 20:07 ` Otavio Salvador
2013-02-17 20:11 ` Fabio Estevam
2013-02-17 20:33 ` Otavio Salvador
2013-02-17 21:21 ` Marek Vasut
2013-02-17 19:45 ` [U-Boot] [PATCH v3 08/10] mx23evk: Enable USB support Otavio Salvador
2013-02-17 19:45 ` [U-Boot] [PATCH v3 09/10] mx23_olinuxino: " Otavio Salvador
2013-02-18 23:16 ` Fabio Estevam
2013-02-19 0:25 ` Otavio Salvador
2013-02-19 1:38 ` Marek Vasut
2013-02-19 11:55 ` Otavio Salvador
2013-02-19 12:21 ` Marek Vasut [this message]
2013-02-19 13:22 ` Otavio Salvador
2013-02-19 19:45 ` Fabio Estevam
2013-02-17 19:45 ` [U-Boot] [PATCH v3 10/10] mx23_olinuxino: Add ethernet support Otavio Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302191321.26735.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox