From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add Boundary Devices Nitrogen6X boards
Date: Wed, 20 Feb 2013 15:20:41 +0100 [thread overview]
Message-ID: <20130220142041.414A520052F@gemini.denx.de> (raw)
In-Reply-To: <1361305248-24598-1-git-send-email-eric.nelson@boundarydevices.com>
Dear Eric Nelson,
In message <1361305248-24598-1-git-send-email-eric.nelson@boundarydevices.com> you wrote:
> +static int detect_hdmi(struct display_info_t const *dev)
> +{
> + return __raw_readb(HDMI_ARB_BASE_ADDR+HDMI_PHY_STAT0) & HDMI_PHY_HPD;
...
> + reg = __raw_readb(
> + HDMI_ARB_BASE_ADDR
> + +HDMI_PHY_CONF0);
etc. etc.
NAK!! We do not allow device access through base address plus offset
notation. Please use a proper C Struct to access thes device.
Also, are you absolutely sure that the __raw_* accessors are the right
thing to use here? Are you really sure no memory barriers etc. are
needed here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The heart is not a logical organ.
-- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4
next prev parent reply other threads:[~2013-02-20 14:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 20:20 [U-Boot] [PATCH] Add Boundary Devices Nitrogen6X boards Eric Nelson
2013-02-19 20:52 ` Benoît Thébaudeau
2013-02-19 21:53 ` Eric Nelson
2013-02-19 22:31 ` Benoît Thébaudeau
2013-02-19 23:01 ` Eric Nelson
2013-02-20 12:05 ` Benoît Thébaudeau
2013-02-20 13:28 ` Benoît Thébaudeau
2013-02-20 14:08 ` Eric Nelson
2013-02-20 14:20 ` Wolfgang Denk [this message]
2013-02-20 16:05 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220142041.414A520052F@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox