From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: bootm: allow skipping fdt memory node fixup
Date: Wed, 20 Feb 2013 09:33:30 -0500 [thread overview]
Message-ID: <20130220143330.GA12654@bill-the-cat> (raw)
In-Reply-To: <5123E311.1070607@gmail.com>
On Tue, Feb 19, 2013 at 02:39:45PM -0600, Rob Herring wrote:
> On 02/19/2013 01:26 PM, Wolfgang Denk wrote:
[snip]
> > I dislike this. If you want to make a property of your device tree
> > "immutable", then you should mark it there as such. Instead of
> > removing the code here, U-Boot should then check for such a property
> > and leave the value unchanged.
>
> There is no such way defined to flag that and I'm not going to invent
> one. It's not that the memory node is immutable, but the default should
> not be "needs fixups". No one puts purposely wrong data in their DT. So
> therefore all data should be immutable? What happens when we need to
> fixup immutable data?
It's not so simple. The first DTs I checked are the am335x ones and I
see they hardcode to 256MB which isn't right, but no one has caught this
since it's blindly fixed up. So as Wolfgang suggests next, we might
need to go with replacing on 0x0 entries and warning when they don't
match what U-Boot has detected.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130220/01c927c5/attachment.pgp>
next prev parent reply other threads:[~2013-02-20 14:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 3:39 [U-Boot] [PATCH 1/2] ARM: bootm: allow skipping fdt memory node fixup Rob Herring
2013-01-25 3:39 ` [U-Boot] [PATCH 2/2] ARM: highbank: remove DRAM bank setup Rob Herring
2013-02-19 19:27 ` Wolfgang Denk
2013-02-19 16:35 ` [U-Boot] [PATCH 1/2] ARM: bootm: allow skipping fdt memory node fixup Tom Rini
2013-02-19 19:26 ` Wolfgang Denk
2013-02-19 20:39 ` Rob Herring
2013-02-19 23:14 ` Wolfgang Denk
2013-02-20 14:07 ` Rob Herring
2013-02-20 14:11 ` Wolfgang Denk
2013-02-20 14:33 ` Tom Rini [this message]
2013-02-20 21:55 ` Peter Korsgaard
2013-02-20 22:13 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220143330.GA12654@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox