From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23
Date: Sun, 24 Feb 2013 11:31:42 +0100 [thread overview]
Message-ID: <201302241131.42480.marex@denx.de> (raw)
In-Reply-To: <1361674109-5384-1-git-send-email-f.koliqi@gmail.com>
Dear Fadil Berisha,
> This patch add timer support to i.MX23 and complete bit fields and values
> on regs-timrot.h.
> Testet on imx23-olinuxino board.
Also document that you renamed some macros, even if I'd prefer if you pulled
those out into separate patch to make this easier to review.
Moreover:
$ ./tools/checkpatch.pl /tmp/\[PATCH\ v2\]\ mxs_timrot_Add\ support\ to\
i.MX23.mbox
ERROR: trailing whitespace
#149: FILE: arch/arm/cpu/arm926ejs/mxs/timer.c:106:
+^Inow = readl(&timrot_regs->hw_timrot_timcount0) >> $
ERROR: trailing whitespace
#376: FILE: arch/arm/include/asm/arch-mxs/regs-timrot.h:261:
+#define^ITIMROT_TIMCOUNT3_HIGH_FIXED_COUNT_MASK^I0xffff $
total: 2 errors, 0 warnings, 287 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
MULTISTATEMENT_MACRO_USE_DO_WHILE
/tmp/[PATCH v2] mxs_timrot_Add support to i.MX23.mbox has style problems, please
review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[...]
next prev parent reply other threads:[~2013-02-24 10:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 2:48 [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23 Fadil Berisha
2013-02-24 10:31 ` Marek Vasut [this message]
2013-02-24 15:41 ` Fadil Berisha
2013-02-24 15:46 ` Marek Vasut
2013-02-24 16:43 ` Fadil Berisha
2013-02-24 17:14 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302241131.42480.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox