From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Sun, 24 Feb 2013 11:31:42 +0100 Subject: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23 In-Reply-To: <1361674109-5384-1-git-send-email-f.koliqi@gmail.com> References: <1361674109-5384-1-git-send-email-f.koliqi@gmail.com> Message-ID: <201302241131.42480.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Fadil Berisha, > This patch add timer support to i.MX23 and complete bit fields and values > on regs-timrot.h. > Testet on imx23-olinuxino board. Also document that you renamed some macros, even if I'd prefer if you pulled those out into separate patch to make this easier to review. Moreover: $ ./tools/checkpatch.pl /tmp/\[PATCH\ v2\]\ mxs_timrot_Add\ support\ to\ i.MX23.mbox ERROR: trailing whitespace #149: FILE: arch/arm/cpu/arm926ejs/mxs/timer.c:106: +^Inow = readl(&timrot_regs->hw_timrot_timcount0) >> $ ERROR: trailing whitespace #376: FILE: arch/arm/include/asm/arch-mxs/regs-timrot.h:261: +#define^ITIMROT_TIMCOUNT3_HIGH_FIXED_COUNT_MASK^I0xffff $ total: 2 errors, 0 warnings, 287 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE /tmp/[PATCH v2] mxs_timrot_Add support to i.MX23.mbox has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. [...]