From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23
Date: Sun, 24 Feb 2013 16:46:26 +0100 [thread overview]
Message-ID: <201302241646.26658.marex@denx.de> (raw)
In-Reply-To: <CACO6GO7H48JJ3-s5ATP_tqtOPJurrhNkekRO5kLm1HFwGw-goA@mail.gmail.com>
Dear Fadil Berisha,
> Dear Marek Vasut
>
> > Also document that you renamed some macros, even if I'd prefer if you
> > pulled those out into separate patch to make this easier to review.
>
> This is documented in comment for patch version v2:
> "v2 - Updated the struct mxs_timrot_regs so the mapping works for all
> registers" Since macro names corespondent to registers names, no need for
> extra documentation.
I meant MXS_INCREMENTER_HZ macro and such.
> > ERROR: trailing whitespace
>
> Will fix in next version
>
> Fadil Berisha
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-02-24 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 2:48 [U-Boot] [PATCH v2] mxs: timrot: Add support to i.MX23 Fadil Berisha
2013-02-24 10:31 ` Marek Vasut
2013-02-24 15:41 ` Fadil Berisha
2013-02-24 15:46 ` Marek Vasut [this message]
2013-02-24 16:43 ` Fadil Berisha
2013-02-24 17:14 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201302241646.26658.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox