From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 28 Feb 2013 16:05:46 +0100 Subject: [U-Boot] [PATCH 0/2] ARM: mmu: Set domain permissions to client access - build warnings! In-Reply-To: <20130228152044.00a8a9fa@lilith> References: <1357668505-30559-1-git-send-email-r.sricharan@ti.com> <20130228152044.00a8a9fa@lilith> Message-ID: <20130228160546.20a5c643@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 28 Feb 2013 15:20:44 +0100, Albert ARIBAUD wrote: > (sorry for any duplicate of this mail) > > Hi R Sricharan, > > On Tue, 8 Jan 2013 23:38:22 +0530, R Sricharan > wrote: > > > Currently for ARM based cpu's, mmu pagetable attributes are set with > > manager permissions for all 4GB address space. Because of this the > > 'execute never (XN)' permission is never checked on read sensitive > > regions which results in speculative aborts. > > > > This series changes the domain permissions of the full 4GB space > > to client access for OMAP socs. This avoids all the speculative > > aborts that are currently seen on OMAP5 secure devices. > > > > Tested on OMAP5 SDP (HS) soc. > > > > This series depends on [1] the patch sent by > > > > > > [1] http://www.mail-archive.com/u-boot at lists.denx.de/msg102709.html > > > > R Sricharan (2): > > ARM: mmu: Introduce weak dram_bank_setup function > > ARM: mmu: Set domain permissions to client access > > > > arch/arm/cpu/armv7/cache_v7.c | 3 ++ > > arch/arm/cpu/armv7/omap-common/hwinit-common.c | 35 ++++++++++++++++++++++++ > > arch/arm/include/asm/cache.h | 1 + > > arch/arm/include/asm/system.h | 14 ++++++++++ > > arch/arm/lib/cache-cp15.c | 13 ++++++++- > > 5 files changed, 65 insertions(+), 1 deletion(-) > > > > Series applied to u-boot-arm/master, thanks! Correction: I'd wrongly inferred from the testing done on OMAP5 that the series would build fine. However it appears that for targets omap4_sdp4430, omap4_panda and omap5_evm, patch 2/2 has warnings: hwinit-common.c: In function 'dram_bank_mmu_setup': hwinit-common.c:279:3: warning: implicit declaration of function 'set_section_dcache' [-Wimplicit-function-declaration] Luckily, I had not committed to the git repo yet. R Sicharan, can you please check and fix this warning? Amicalement, -- Albert.