From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Fri, 1 Mar 2013 14:15:00 -0500 Subject: [U-Boot] [PATCH] cmd_mem: Decode the mtest start and end values from fdt In-Reply-To: <20130301160648.CD661200527@gemini.denx.de> References: <10597224-d520-4a3f-8185-5de018ee5046@TX2EHSMHS026.ehs.local> <20130301160648.CD661200527@gemini.denx.de> Message-ID: <20130301191500.GP25797@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Mar 01, 2013 at 05:06:48PM +0100, Wolfgang Denk wrote: > Dear Jagannadha Sutradharudu Teki, > > In message <10597224-d520-4a3f-8185-5de018ee5046@TX2EHSMHS026.ehs.local> you wrote: > > This patch provides a support to decode the mtest start > > and end values from fdt config node. > > > > Signed-off-by: Jagannadha Sutradharudu Teki > > Tested-by: Jagannadha Sutradharudu Teki > > --- > > common/cmd_mem.c | 6 ++++-- > > common/main.c | 18 ++++++++++++++++++ > > 2 files changed, 22 insertions(+), 2 deletions(-) > > You are adding code here which may bot be user and/or wanted by the > majority of boards, so please make it configureable (and document the > new config option). In addition, if we're going to start whacking around in here, can we just make this function bail if not passed a start and end address? I'm a little torn since on the one hand this is a known function, but on the other it's not something one would expect to be used outside of testing environments. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: