From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MAKEALL: allow regex matches for -s option
Date: Tue, 05 Mar 2013 22:37:37 +0100 [thread overview]
Message-ID: <20130305213737.B503D20003F@gemini.denx.de> (raw)
In-Reply-To: <1362518101-5742-1-git-send-email-swarren@wwwdotorg.org>
Dear Stephen Warren,
In message <1362518101-5742-1-git-send-email-swarren@wwwdotorg.org> you wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> This allows:
>
> MAKEALL -s tegra*
>
> to replace:
>
> MAKEALL -s tegra20 -s tegra30 -s tegra114
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> MAKEALL | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MAKEALL b/MAKEALL
> index 5b06c54..0ed6986 100755
> --- a/MAKEALL
> +++ b/MAKEALL
> @@ -101,9 +101,9 @@ while true ; do
> -s|--soc)
> # echo "Option SoC: argument \`$2'"
> if [ "$opt_s" ] ; then
> - opt_s="${opt_s%)} || \$6 == \"$2\")"
> + opt_s="${opt_s%)} || \$6 == \"$2\" || \$6 ~ /$2/)"
Is this actually correct? I see 2 x closing parens here, with no
matching open parens?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Remember, an int is not always 16 bits. I'm not sure, but if the
80386 is one step closer to Intel's slugfest with the CPU curve that
is aymptotically approaching a real machine, perhaps an int has been
implemented as 32 bits by some Unix vendors...? - Derek Terveer
next prev parent reply other threads:[~2013-03-05 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 21:15 [U-Boot] [PATCH] MAKEALL: allow regex matches for -s option Stephen Warren
2013-03-05 21:37 ` Wolfgang Denk [this message]
2013-03-05 21:43 ` Stephen Warren
2013-03-05 23:08 ` Tom Rini
2013-03-05 23:39 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130305213737.B503D20003F@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox