[U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface

Marek Vasut
2013-03-06T00:55:46Z

Dear Tom Rini,

> On Wed, Mar 06, 2013 at 12:54:45AM +0100, Marek Vasut wrote:
> > Dear Tom Rini,
> >
> > > On 03/05/2013 06:24 PM, Marek Vasut wrote:
> > > > Dear Lukasz Majewski,
> > > >
> > > >> Hi Marek,
> > > >>
> > > >>> Dear Lukasz Majewski,
> > > >>>
> > > >>>> This commit fixes problems with some non-standard requests
> > > >>>> send with device address instead of interface address
> > > >>>> (bmRequestType.Receipent field).
> > > >>>>
> > > >>>> This happens with dfu-util (debian version: 0.5), which
> > > >>>> address non standard requests (like w_value=0x21 and
> > > >>>> bRequest=GET_DESCRIPTOR) to device. Without this fix, the
> > > >>>> above request is STALLED, and hence causes dfu-util to assume
> > > >>>> some standard configuration (packet size = 1024B instead of
> > > >>>> 4096B) In turn it displays following errors: Error obtaining
> > > >>>> DFU functional descriptor Warning: Assuming DFU version 1.0
> > > >>>> Warning: Transfer size can not be detected ... Warning:
> > > >>>> Trying default transfer size 1024
> > > >>>>
> > > >>>> This fix allows passing non-standard request to function
> > > >>>> setup code, where it shall be handled.
> > > >>>>
> > > >>>> Tested at: Trats (exynos4210) Tested with:DFU and UMS
> > > >>>> gadgets
> > > >>>
> > > >>> Can you please repost all the patches you want applied on
> > > >>> u-boot-usb ? I'm completely lost in all this DFU stuff.
> > > >>
> > > >> This is only one patch to replace patch done by Pantelis:
> > > >>
> > > >> Patch to replace (revert): dfu: Send correct DFU response from
> > > >> composite_setup SHA1: fef31049fa06e516945114195eb14ac3549d0ad2
> > > >>
> > > >> And this shall be replaced with posted patch.
> > > >>
> > > >> Another patches (with UMS gadget support - done by Piotr
> > > >> Wilczek), also shall be added to u-boot-usb tree:
> > > >>
> > > >> http://patchwork.ozlabs.org/patch/219744/
> > > >> http://patchwork.ozlabs.org/patch/219746/
> > > >> http://patchwork.ozlabs.org/patch/219745/
> > > >
> > > > Ok, please check the u-boot-usb ... if it's OK, I will send Tom a
> > > > pullrq (finally). Tom, do you still accept those for .04 ?
> > >
> > > As of earlier in the day it still had Pantelis' patch for sending
> > > files larger than memory which breaks all filesystem-based writes, so
> > > that needs to go. Lukasz and I are discussing how to deal with that.
> >
> > IIRC I killed that patch.
>
> In u-boot-usb/master currently:
> commit a09f955db6ad7031bd715a615fb8b90d671a14d4
> Author: Pantelis Antoniou <panto@antoniou-consulting.com>
> Date: Fri Nov 30 08:01:12 2012 +0000
>
> dfu: Support larger than memory transfers.
>
> Is one of the two that needed to go. The patch in this thread replaced
> the other one that you did drop.

True, we now have the proper one applied to my understanding.

Best regards,
Marek Vasut