[U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface

Tom Rini
2013-03-05T23:44:19Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/05/2013 06:24 PM, Marek Vasut wrote:
> Dear Lukasz Majewski,
>
>> Hi Marek,
>>
>>> Dear Lukasz Majewski,
>>>
>>>> This commit fixes problems with some non-standard requests
>>>> send with device address instead of interface address
>>>> (bmRequestType.Receipent field).
>>>>
>>>> This happens with dfu-util (debian version: 0.5), which
>>>> address non standard requests (like w_value=0x21 and
>>>> bRequest=GET_DESCRIPTOR) to device. Without this fix, the
>>>> above request is STALLED, and hence causes dfu-util to assume
>>>> some standard configuration (packet size = 1024B instead of
>>>> 4096B) In turn it displays following errors: Error obtaining
>>>> DFU functional descriptor Warning: Assuming DFU version 1.0
>>>> Warning: Transfer size can not be detected ... Warning:
>>>> Trying default transfer size 1024
>>>>
>>>> This fix allows passing non-standard request to function
>>>> setup code, where it shall be handled.
>>>>
>>>> Tested at: Trats (exynos4210) Tested with:DFU and UMS
>>>> gadgets
>>>
>>> Can you please repost all the patches you want applied on
>>> u-boot-usb ? I'm completely lost in all this DFU stuff.
>>
>> This is only one patch to replace patch done by Pantelis:
>>
>> Patch to replace (revert): dfu: Send correct DFU response from
>> composite_setup SHA1: fef31049fa06e516945114195eb14ac3549d0ad2
>>
>> And this shall be replaced with posted patch.
>>
>> Another patches (with UMS gadget support - done by Piotr
>> Wilczek), also shall be added to u-boot-usb tree:
>>
>> http://patchwork.ozlabs.org/patch/219744/
>> http://patchwork.ozlabs.org/patch/219746/
>> http://patchwork.ozlabs.org/patch/219745/
>
> Ok, please check the u-boot-usb ... if it's OK, I will send Tom a
> pullrq (finally). Tom, do you still accept those for .04 ?

As of earlier in the day it still had Pantelis' patch for sending
files larger than memory which breaks all filesystem-based writes, so
that needs to go. Lukasz and I are discussing how to deal with that.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRNoNSAAoJENk4IS6UOR1WnDkP+QE7ihcrFz0u5v2wAhkjwtaZ
etpl6oL/rB7jA6jK9zDYkyoc/Bf9A9/ffxsfGruP8kzjK2BTwHizs/Hz4I8Z90k6
6g4S7DUY4kx9t20Iyyswwuo8Bs0MXuEyDSS1a3kWXsB1110eUXd6xBsQoOKv5BeK
1UO29ZFMRJAnIpKBSrrGNE0e8xG8fnF1y8/Wos8OAk240DKoMPTF1lZEB5TEkbtN
7xePk4XLGClePj8CH8iIBj2YDo5kjRPUCZ2zSd6niayVrp5On5as+Fn9XTvWiQYG
UjLDbeAhNinzRJx9q8sB2dxXq2sSh+8ehtKZgnQCwOuj0bV0Ok4um0FP7DKN1Z+K
COvJdKC629rZ9cyc/kLfXtJzEYBJwK+OsLjLHOf7YuuhQpcPcugZWmdc8LZt6QMA
aL61JGTCfF80PVO8jAjWkJjniTHTSQRL+Adt91wej9D8e246/SbzFMqjjpTWQvVB
RcR6fUwKdcMwT+RKAJybYH8z3tqwiRQXleBPs6NqcRYV7E8AHzpeMUh5v7m2Gz/P
8y+ea4v8Nglq79UnYmeqCHmvMO0ZqUpb8/+hB35xfkyuIHstx3J784NHOaQ7IZqj
iJZ/Stf3De+ASddDFeAldoyc3EdT2k98gYUKpitExTOB5EbWKrK781JOEC0q+iSb
+xUyux8npF6Rhhf55Rm7
=DAuM
-----END PGP SIGNATURE-----