[U-Boot] [PATCH] usb:composite:fix Provide function data when addressing device with only one interface

Lukasz Majewski
2013-03-01T15:34:28Z

Hi Marek,

> Dear Lukasz Majewski,
>
> > This commit fixes problems with some non-standard requests send with
> > device address instead of interface address (bmRequestType.Receipent
> > field).
> >
> > This happens with dfu-util (debian version: 0.5), which address non
> > standard requests (like w_value=0x21 and bRequest=GET_DESCRIPTOR) to
> > device. Without this fix, the above request is STALLED, and hence
> > causes dfu-util to assume some standard configuration (packet size
> > = 1024B instead of 4096B) In turn it displays following errors:
> > Error obtaining DFU functional descriptor
> > Warning: Assuming DFU version 1.0
> > Warning: Transfer size can not be detected
> > ...
> > Warning: Trying default transfer size 1024
> >
> > This fix allows passing non-standard request to function setup
> > code, where it shall be handled.
> >
> > Tested at: Trats (exynos4210)
> > Tested with:DFU and UMS gadgets
>
> Can you please repost all the patches you want applied on
> u-boot-usb ? I'm completely lost in all this DFU stuff.

This is only one patch to replace patch done by Pantelis:

Patch to replace (revert):
dfu: Send correct DFU response from composite_setup
SHA1: fef31049fa06e516945114195eb14ac3549d0ad2

And this shall be replaced with posted patch.

Another patches (with UMS gadget support - done by Piotr Wilczek), also
shall be added to u-boot-usb tree:

http://patchwork.ozlabs.org/patch/219744/
http://patchwork.ozlabs.org/patch/219746/
http://patchwork.ozlabs.org/patch/219745/

>
> Best regards,
> Marek Vasut

--
Best regards,

Lukasz Majewski

Samsung R&D Poland (SRPOL) | Linux Platform Group