From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mxs: spl_mem_init: Align DDR2 init with FSL bootlets source
Date: Wed, 6 Mar 2013 16:41:54 +0100 [thread overview]
Message-ID: <201303061641.54406.marex@denx.de> (raw)
In-Reply-To: <CAP9ODKrrx9M=7NwttgjXAZmM8xO6dEN3CY4B-s=wBJUsj7GV9A@mail.gmail.com>
Dear Otavio Salvador,
> On Wed, Mar 6, 2013 at 11:31 AM, Marek Vasut <marex@denx.de> wrote:
> > Dear Otavio Salvador,
> >
> >> On Thu, Feb 28, 2013 at 7:59 PM, Fabio Estevam <festevam@gmail.com> wrote:
> >> > From: Fabio Estevam <fabio.estevam@freescale.com>
> >> >
> >> > Currently the following kernel hang happens when loading a 2.6.35
> >> > kernel from Freeescale on a mx28evk board:
> >> >
> >> > RPC: Registered tcp transport module.
> >> > RPC: Registered tcp NFSv4.1 backchannel transport module.
> >> > Bus freq driver module loaded
> >> > IMX usb wakeup probe
> >> > usb h1 wakeup device is registered
> >> > mxs_cpu_init: cpufreq init finished
> >> > ...
> >> >
> >> > Loading the same kernel using the bootlets from the
> >> > imx-bootlets-src-10.12.01 package, the hang does not occur.
> >> >
> >> > Comparing the DDR2 initialization from the bootlets code against the
> >> > U-boot one, we can notice some mismatches, and after applying the same
> >> > initialization into U-boot the 2.6.35 kernel can boot normally.
> >> >
> >> > Also tested with 'mtest' command, which runs succesfully.
> >> >
> >> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
> >
> > Otavio, did you review the changes done in this patch ?
>
> This is the setup used in FSL U-Boot and it fixes 2.6.35.3 cpufreq
> kernel hang; it is good enough for me to accept it. If you care
> enough, go ahead and check every change bit.
That is indeed the plan, I will Ack this after I am done with it. It will still
make it for .04, dont worry.
You should not Ack patches you did not even test nor validate, since the value
of your Ack is declining.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2013-03-06 15:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 22:59 [U-Boot] [PATCH v2] mxs: spl_mem_init: Align DDR2 init with FSL bootlets source Fabio Estevam
2013-03-06 13:44 ` Otavio Salvador
2013-03-06 14:31 ` Marek Vasut
2013-03-06 15:33 ` Otavio Salvador
2013-03-06 15:41 ` Marek Vasut [this message]
2013-03-06 15:44 ` Otavio Salvador
2013-03-06 15:46 ` Marek Vasut
2013-03-13 8:16 ` Stefano Babic
2013-03-13 14:18 ` Fabio Estevam
2013-03-13 14:22 ` Fabio Estevam
2013-03-14 5:09 ` Lauri Hintsala
2013-03-18 13:15 ` Otavio Salvador
2013-03-13 16:01 ` Marek Vasut
2013-03-13 16:07 ` Stefano Babic
2013-03-13 15:15 ` Marek Vasut
2013-03-19 6:52 ` Lauri Hintsala
2013-03-19 11:35 ` Otavio Salvador
2013-03-19 11:43 ` Lauri Hintsala
2013-03-23 16:56 ` Fabio Estevam
2013-03-19 12:36 ` Fabio Estevam
2013-03-20 5:17 ` Lauri Hintsala
2013-03-20 5:33 ` Fabio Estevam
2013-03-20 8:26 ` Stefano Babic
2013-03-20 10:07 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201303061641.54406.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox