From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sun, 10 Mar 2013 08:51:40 +0100
Subject: [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard
	dual lite
In-Reply-To: <1362873704-23598-1-git-send-email-festevam@gmail.com>
References: <1362873704-23598-1-git-send-email-festevam@gmail.com>
Message-ID: <20130310075140.55FE4200642@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Fabio Estevam,

In message <1362873704-23598-1-git-send-email-festevam@gmail.com> you wrote:
> 
> Add initial support for Wandboard dual lite.
...

> Changes since v1:
> - Use get_ram_size
> - Remove ARP_TIMEOUT
> - Remove unneeded "1u"

Thanks.  I have still a question:

> +int dram_init(void)
> +{
> +	gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
> +
> +	return 0;
> +}

I see this new code does not reference imx_ddr_size() any more.  If
it's so easy to switch to get_ram_size(), should we not then also
convert the existing MX53 and MX6 boards to using get_ram_size(), and
remove the then unneeded imx_ddr_size() code?

Or would there be any drawbacks?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As far as the laws of mathematics refer to reality, they are not cer-
tain, and as far as they are certain, they do not refer  to  reality.
                                                   -- Albert Einstein