public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2] Add Boundary Devices Nitrogen6X boards
Date: Sun, 10 Mar 2013 09:02:09 +0100	[thread overview]
Message-ID: <20130310080209.656C7200642@gemini.denx.de> (raw)
In-Reply-To: <513BD8AA.4060000@boundarydevices.com>

Dear Troy,

In message <513BD8AA.4060000@boundarydevices.com> you wrote:
> On 3/9/2013 5:04 PM, Eric Nelson wrote:
> > diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c
> > new file mode 100644
> > index 0000000..147bd91
> > --- /dev/null
> > +++ b/board/boundary/nitrogen6x/nitrogen6x.c
> > @@ -0,0 +1,895 @@
> > +int dram_init(void)
> > +{
> > +	gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
> 
> This will hang a solo if
> 
> PHYS_SDRAM_SIZE is bigger than actual memory size
> 
> which makes calling get_ram_size pretty useless.

If this is the case, then there is a bug in the code resp. the code is
incomplete.  get_ram_size() has always been used to detect smaller
than the maximum possible (configured) RAM sizes; actually this is
it's main purpose.

If this is not really working, then it needs to be fixed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Monday is an awful way to spend one seventh of your life.

  reply	other threads:[~2013-03-10  8:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-10  0:04 [U-Boot] [PATCH V2] Add Boundary Devices Nitrogen6X boards Eric Nelson
2013-03-10  0:49 ` Troy Kisky
2013-03-10  8:02   ` Wolfgang Denk [this message]
2013-03-10 14:15   ` Eric Nelson
2013-03-10  7:59 ` Wolfgang Denk
2013-03-10 15:09   ` Eric Nelson
2013-03-10 15:45     ` Wolfgang Denk
2013-03-10 16:25       ` Eric Nelson
2013-03-10 22:03         ` Wolfgang Denk
2013-03-10 23:36           ` Eric Nelson
2013-03-11 11:15             ` Wolfgang Denk
2013-03-11 12:04               ` Stefano Babic
2013-03-11 13:18                 ` Fabio Estevam
2013-03-11 13:44                   ` Stefano Babic
2013-03-11 13:54                     ` Fabio Estevam
2013-03-11 14:02                     ` Eric Nelson
2013-03-11 14:30                       ` Stefano Babic
2013-03-11 14:39                         ` Tom Rini
2013-03-11 13:37               ` Eric Nelson
2013-03-11 16:48                 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130310080209.656C7200642@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox