From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sun, 10 Mar 2013 16:42:14 +0100 Subject: [U-Boot] [PATCH v2] mx6dl: Add initial support for Wandboard dual lite In-Reply-To: <513C9755.3040802@boundarydevices.com> References: <1362873704-23598-1-git-send-email-festevam@gmail.com> <20130310075140.55FE4200642@gemini.denx.de> <513C9755.3040802@boundarydevices.com> Message-ID: <20130310154214.05D582010CD@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Eric Nelson, In message <513C9755.3040802@boundarydevices.com> you wrote: > > > I see this new code does not reference imx_ddr_size() any more. If > > it's so easy to switch to get_ram_size(), should we not then also > > convert the existing MX53 and MX6 boards to using get_ram_size(), and > > remove the then unneeded imx_ddr_size() code? > > > > Or would there be any drawbacks? > > > > In the specific case of Nitrogen6X, we're defining different > configurations for each of the memory arrangements, so we could > skip the call to imx_ddr_size(). Well, that was the starting point of my questions - don;t you want to have a single image runnign on all of your systems? That's exactly get_ram_size() has been made for... > For that matter, we could skip the call to get_ram_size() entirely > because we're configuring each of the DDR settings very explicitly. get_ram_size() is not about configuring, but about verifying / checking the result of such a configuration. > Since there are timing difference between the x128M and x256M > DDR chips we're using, we've split them off into separate files: That's OK - but this is still no reason not to support all these configurations in a single U-Boot image. After all, this is exactly how U-Boot has been designed right from the beginning. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Committee, n.: A group of men who individually can do nothing but as a group decide that nothing can be done. - Fred Allen