public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/2] bfin: Remove spi dma function in bf5xx.
Date: Tue, 12 Mar 2013 07:19:04 -0400	[thread overview]
Message-ID: <201303120719.06528.vapier@gentoo.org> (raw)
In-Reply-To: <1362381609-23716-1-git-send-email-sonic.adi@gmail.com>

On Monday 04 March 2013 02:20:08 Sonic Zhang wrote:
> From: Scott Jiang <scott.jiang.linux@gmail.com>
> 
> BF5xx rx dma causes spi flash random read error.
> Accually spi controller has problems both on tx and rx dma.
> So remove spi dma support in u-boot.

this is wrong, and imo, unnecessary.  it's wrong because using DMA gains a lot 
of speed increases, and works for in many cases (i haven't seen cases where it 
didn't work, but i haven't been actively developing in the last year of 
course).  it's unnecessary because there's already a CONFIG_xxx option to 
disable it if your platform is having problems and you can't figure things out, 
and don't need the speed gains.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130312/635c7fdb/attachment.pgp>

  parent reply	other threads:[~2013-03-12 11:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04  7:20 [U-Boot] [PATCH v1 1/2] bfin: Remove spi dma function in bf5xx Sonic Zhang
2013-03-04  7:20 ` [U-Boot] [PATCH v1 2/2] bfin: discard invalid data and clear RXS in bf5xx spi driver Sonic Zhang
2013-03-12 11:19 ` Mike Frysinger [this message]
2013-03-13  3:13   ` [U-Boot] [PATCH v1 1/2] bfin: Remove spi dma function in bf5xx Scott Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201303120719.06528.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox