From mboxrd@z Thu Jan 1 00:00:00 1970 From: Albert ARIBAUD Date: Thu, 14 Mar 2013 14:15:02 +0100 Subject: [U-Boot] [PATCH V4] nitrogen: Use unsigned long to specify the total RAM size In-Reply-To: <1363248561-11974-1-git-send-email-sbabic@denx.de> References: <1363215553-27684-2-git-send-email-festevam@gmail.com> <1363248561-11974-1-git-send-email-sbabic@denx.de> Message-ID: <20130314141502.779d6e21@lilith> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Stefano, On Thu, 14 Mar 2013 09:09:21 +0100, Stefano Babic wrote: > From: "fabio.estevam at freescale.com" > > When building for the nitrogen boards with 2GB the following warning happens: > > nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow] > > 2GB can not fit in 32-bits, so use ulong instead. > > Reported-by: Albert Aribaud > Signed-off-by: Fabio Estevam > Signed-off-by: Stefano Babic This somehow is redundant with Fabio's patch 2/2 with the same summary, right? Stefano: once Fabio's series is OK, - either you rollback your ToT, apply Fabio's series before it, and then send out an amended PR, which is more work but makes your tree build-clean; - or I apply Fabio's series then your existing PR, which is less work but leaves your current ToT non-build-clean until you merge back from ARM (or mainline once I do my own PR). What do you prefer? I would favor the first option, FWIW. Amicalement, -- Albert.