From: Matt Porter <mporter@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/3] am335x_evm: add support for BeagleBone Black DT name
Date: Thu, 14 Mar 2013 11:07:10 -0400 [thread overview]
Message-ID: <20130314150710.GA18335@beef> (raw)
In-Reply-To: <38145F0B-AB20-47A6-9089-9D21A5A509FF@dominion.thruhere.net>
On Thu, Mar 14, 2013 at 07:53:07AM +0100, Koen Kooi wrote:
>
> Op 13 mrt. 2013, om 21:19 heeft Matt Porter <mporter@ti.com> het volgende geschreven:
>
> > On Wed, Mar 13, 2013 at 08:02:26PM +0100, Koen Kooi wrote:
> >>
> >> Op 13 mrt. 2013, om 16:07 heeft Nishanth Menon <nm@ti.com> het volgende geschreven:
> >>
> >>> On 16:05-20130313, Koen Kooi wrote:
> >>>>
> >>>> Op 13 mrt. 2013, om 16:02 heeft Nishanth Menon <nm@ti.com> het volgende geschreven:
> >>>>
> >>>>> On Wed, Mar 13, 2013 at 9:57 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> >>>>>>
> >>>>>> Op 13 mrt. 2013, om 15:35 heeft Nishanth Menon <nm@ti.com> het volgende geschreven:
> >>>>>>
> >>>>>>> On 10:20-20130313, Tom Rini wrote:
> >>>>>>>> From: Koen Kooi <koen@dominion.thruhere.net>
> >>>>>>>>
> >>>>>>>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >>>>>>>> Acked-by: Peter Korsgaard <jacmet@sunsite.dk>
> >>>>>>>> ---
> >>>>>>>> include/configs/am335x_evm.h | 2 ++
> >>>>>>>> 1 file changed, 2 insertions(+)
> >>>>>>>>
> >>>>>>>> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h
> >>>>>>>> index 33ee2c4..abf4e39 100644
> >>>>>>>> --- a/include/configs/am335x_evm.h
> >>>>>>>> +++ b/include/configs/am335x_evm.h
> >>>>>>>> @@ -87,6 +87,8 @@
> >>>>>>>> "findfdt="\
> >>>>>>>> "if test $board_name = A335BONE; then " \
> >>>>>>>> "setenv fdtfile am335x-bone.dtb; fi; " \
> >>>>>>>> + "if test $board_name = A335BNLT; then " \
> >>>>>>>> + "setenv fdtfile am335x-bonelt.dtb; fi; " \
> >>>>>>> could we not use am335x-boneblack.dtb instead?
> >>>>>>
> >>>>>> it's bonelt in the kernel, so boneblack would fail to load a dtb
> >>>>> $ git describe
> >>>>> v3.9-rc2
> >>>>> $ ls arch/arm/boot/dts/*bone*.dts*
> >>>>> arch/arm/boot/dts/am335x-bone.dts
> >>>>> ???
> >>>>
> >>>> What a surprise, missing stuff in mainline! It's present in the vendor kernel, which is what is shipping with the board.
> >>> No surprise there as marketing names are finalized close to product
> >>> launches. If there is an vendor u-boot, it can remain in sync with what
> >>> ever the vendor kernel is. If it is upstream, we might want to think
> >>> longterm.
> >>
> >> I'm in charge of pushing the am335x-bonelt.dts upstream to Linus and I'd like to keep everything in sync. I'm not fond of renaming it again, the EEPROM says BNLT, not BNB :)
> >
> > That's a horrible reason to confuse users. The EEPROM contents are
> > irrelevant. Users look for something to match the board name, this
> > does not. It's wrong.
>
> It is stupid, but that's what you get for renaming boards. The real problem with this is that it is a flag day, the kernel and u-boot need to change both at the same time. And after that you'll have a mismatch if you use different versions.
>
> Anyway, patches welcome for the vendor kernel to rename it.
The pull request is https://github.com/beagleboard/kernel/pull/33
Should be easy to keep those in sync as you control the s/w going
out on all the new BeagleBones. The type of people that have early
boards can all handle s/w changes like this otherwise they shouldn't
be in the alpha test group.
Anything else that prevents us from fixing this fdtfile hunk now?
-Matt
next prev parent reply other threads:[~2013-03-14 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 14:20 [U-Boot] [PATCH v2 0/3] am335x_evm: Switch to DT boot, add another platform Tom Rini
2013-03-13 14:20 ` [U-Boot] [PATCH v2 1/3] am335x_evm: add support for BeagleBone Black DT name Tom Rini
2013-03-13 14:35 ` Nishanth Menon
2013-03-13 14:57 ` Koen Kooi
2013-03-13 15:02 ` Nishanth Menon
2013-03-13 15:05 ` Koen Kooi
2013-03-13 15:07 ` Nishanth Menon
2013-03-13 19:02 ` Koen Kooi
2013-03-13 19:26 ` Nishanth Menon
2013-03-13 20:19 ` Matt Porter
2013-03-14 6:53 ` Koen Kooi
2013-03-14 15:07 ` Matt Porter [this message]
2013-03-13 14:20 ` [U-Boot] [PATCH v2 2/3] am335x_evm: Enable CMD_EXT4 and CMD_FS_GENERIC, add bootpart to env Tom Rini
2013-03-13 15:04 ` Peter Korsgaard
2013-03-13 15:12 ` Tom Rini
2013-03-13 17:40 ` Peter Korsgaard
2013-03-13 14:20 ` [U-Boot] [PATCH v2 3/3] am335x_evm: Add more variables and switch to DT booting Tom Rini
2013-03-13 15:06 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314150710.GA18335@beef \
--to=mporter@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox