From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4] nitrogen: Use unsigned long to specify the total RAM size
Date: Thu, 14 Mar 2013 16:18:41 +0100 [thread overview]
Message-ID: <20130314161841.75eca394@lilith> (raw)
In-Reply-To: <5141DA0B.8060208@denx.de>
Hi Stefano,
On Thu, 14 Mar 2013 15:09:15 +0100, Stefano Babic <sbabic@denx.de>
wrote:
> On 14/03/2013 14:15, Albert ARIBAUD wrote:
> > Hi Stefano,
> >
> > On Thu, 14 Mar 2013 09:09:21 +0100, Stefano Babic <sbabic@denx.de>
> > wrote:
> >
> >> From: "fabio.estevam at freescale.com" <fabio.estevam@freescale.com>
> >>
> >> When building for the nitrogen boards with 2GB the following warning happens:
> >>
> >> nitrogen6x.c:89:38: warning: integer overflow in expression [-Woverflow]
> >>
> >> 2GB can not fit in 32-bits, so use ulong instead.
> >>
> >> Reported-by: Albert Aribaud <albert.u.boot@aribaud.net>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >> Signed-off-by: Stefano Babic <sbabic@denx.de>
> >
> > This somehow is redundant with Fabio's patch 2/2 with the same summary,
> > right?
> >
>
> We sent quite at the same time - I will discharge mine.
>
> > Stefano: once Fabio's series is OK,
> >
> > - either you rollback your ToT, apply Fabio's series before it, and
> > then send out an amended PR, which is more work but makes your tree
> > build-clean;
> >
> > - or I apply Fabio's series then your existing PR, which is less
> > work but leaves your current ToT non-build-clean until you merge back
> > from ARM (or mainline once I do my own PR).
> >
> > What do you prefer? I would favor the first option, FWIW.
>
> I prefer to apply Fabio's patches on top of u-boot-imx and send an
> amended PR. This is also my favorite option. What do you mean with
> rollback the ToT ? As I have already pushed on the server, I do not like
> to rebase it or things like that. My idea is only to apply the patches
> and send after that a new PR to you.
That's fine. :)
> Stefano
Amicalement,
--
Albert.
next prev parent reply other threads:[~2013-03-14 15:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 22:59 [U-Boot] [PATCH v2 1/2] nitrogen6x: Fix RAM size variable Fabio Estevam
2013-03-13 22:59 ` [U-Boot] [PATCH v2 2/2] nitrogen: Use unsigned long to specify the total RAM size Fabio Estevam
2013-03-14 7:42 ` Stefano Babic
2013-03-14 8:03 ` [U-Boot] [PATCH V3] " Stefano Babic
2013-03-14 8:08 ` Stefano Babic
2013-03-14 8:09 ` [U-Boot] [PATCH V4] " Stefano Babic
2013-03-14 11:38 ` Wolfgang Denk
2013-03-14 12:25 ` Fabio Estevam
2013-03-14 13:15 ` Albert ARIBAUD
2013-03-14 14:09 ` Stefano Babic
2013-03-14 15:18 ` Albert ARIBAUD [this message]
2013-03-14 7:36 ` [U-Boot] [PATCH v2 1/2] nitrogen6x: Fix RAM size variable Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314161841.75eca394@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox