From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.
Date: Thu, 14 Mar 2013 13:36:48 -0400 [thread overview]
Message-ID: <20130314173648.GX23324@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5AVbVjXhHvMmZYRmroBWZYXb_-_4eNiQVTUjOOXD=iDhg@mail.gmail.com>
On Thu, Mar 14, 2013 at 02:01:20PM -0300, Fabio Estevam wrote:
> Hi Wolfgang,
>
> On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk <wd@denx.de> wrote:
> > Dear Fabio Estevam,
> >
> > In message <1363228354-29534-1-git-send-email-festevam@gmail.com> you wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Add initial support for Wandboard.
> >
> > Subject and commit message are redundant, resulting in text like this:
> >
> > Add initial support for Wandboard dual lite and solo.
> >
> > Add initial support for Wandboard.
> >
> > Please remove the second line.
>
> Thanks for the review. I will address your comments and send v5 after
> the nitrogen patches are applied into u-boot.imx.
>
> >> +#define CONFIG_BOOTDELAY 1
> >
> > Is there any reason for not chosing the more standard 5 second delay?
>
> Ok, so let's go with 3 seconds then ;-)
There's a pretty even distribution of 1 3 and 5 second delays (with a
few 10s, 2s and 6s). If they want 1, let them have 1, it's not hard to
break into, you have U-Boot starting + 1sec.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130314/802d8aa3/attachment.pgp>
next prev parent reply other threads:[~2013-03-14 17:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 2:32 [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo Fabio Estevam
2013-03-14 12:31 ` Wolfgang Denk
2013-03-14 17:01 ` Fabio Estevam
2013-03-14 17:36 ` Tom Rini [this message]
2013-03-14 20:36 ` Wolfgang Denk
2013-03-14 21:01 ` Tom Rini
2013-03-14 22:17 ` Scott Wood
2013-03-14 20:24 ` Wolfgang Denk
2013-03-15 14:55 ` Stefano Babic
2013-03-15 17:27 ` Wolfgang Denk
2013-03-15 18:26 ` Stefano Babic
2013-03-15 20:48 ` Wolfgang Denk
2013-03-14 20:13 ` Fabio Estevam
2013-03-14 20:37 ` Wolfgang Denk
2013-03-15 18:21 ` Fabio Estevam
2013-03-15 20:32 ` Fabio Estevam
2013-03-15 20:52 ` Wolfgang Denk
2013-03-20 10:12 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314173648.GX23324@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox